Mapgen: Remove unused mgv7 code and some unused biometypes #7164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramat
added
@ Script API
@ Mapgen
Maintenance
paramat
changed the title
|
👍 |
nerzhul
approved these changes
Mar 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in the mgv7 boneyard is old mgv7 code, some of it very old from an early version of mgv7, the river code is an early experiment by hmmmm. It's not very useful stuff in my opinion and will still be present in history, no point keeping old code around like this.
Biometypes
This was an old experiment by hmmmm (Dec 2012 before he was a dev 96898c1) that didn't go anywhere
Currently biometype 'normal' is set for all biomes, having alternatives could become useful in future so i have left all code functional but just removed the highly unlikely alternative biometype names.
'Liquid' and 'flat' can both be done by mgflat.
'Nether' and 'aether' are copying MC, nothing wrong with extra realms but we won't be using these names.