Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow larger asset files #7744

Open
hecktest opened this issue Sep 24, 2018 · 3 comments
Open

Allow larger asset files #7744

hecktest opened this issue Sep 24, 2018 · 3 comments
Labels
Bug Issues that were confirmed to be a bug Feature request Issues that request the addition or enhancement of a feature @ Network @ Server / Client / Env.

Comments

@hecktest
Copy link
Contributor

Issue type

Half bug half request

Minetest version

any

OS / Hardware

any

Summary

Minetest will currently refuse to accept asset files above a certain magical amount of bytes, defined by the MAX_RELIABLE_WINDOW_SIZE constant. I suppose this is related to sending files over the network, but it pops up in single player as well.
Minetest also seems not to compress assets before comparing them with said number (or at all, which would be very bad), making the limit very easy to hit with animated model files.
The solution, of course, is to compress files and send them in pieces if they still exceed the window size. (most assets will not hit both limits, but certain animated player models are a possibility)

@sfan5 sfan5 added @ Server / Client / Env. @ Network Feature request Issues that request the addition or enhancement of a feature labels Sep 24, 2018
@Calinou
Copy link
Member

Calinou commented Sep 25, 2018

Based on the issue description, this can be worked around by setting up a remote media server (essentially an HTTP server used by clients to download assets).

@hecktest
Copy link
Contributor Author

No, that is irrelevant to this issue.

@rubenwardy
Copy link
Member

The best fix would be fragmentation, ideally with compression, as said

No, that is irrelevant to this issue.

It is relevant as it will bypass this issue by loading the media over HTTP instead. It's not a good solution though, and means it would only really work on a server

@paramat paramat added the Bug Issues that were confirmed to be a bug label Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues that were confirmed to be a bug Feature request Issues that request the addition or enhancement of a feature @ Network @ Server / Client / Env.
Projects
None yet
Development

No branches or pull requests

5 participants