Night sky: Fix brightness threshold for applying night colours #7859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramat
added
@ Client / Audiovisuals
Trivial
Previously, 'time_brightness' never fell below the threshold so night sky colours were not applied. Increase the threshold value. But now also set it to a value less sensitive to possible future small changes in 'time_brightness', by setting it halfway between the 'time_brightness' values for darkest night and first stage of dawn.
paramat
changed the title
|
Updated with a less sensitive midpoint value, retested. |
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
…est#7859) Previously, 'time_brightness' never fell below the threshold so night sky colours were not applied. Increase the threshold value. But now also set it to a value less sensitive to possible future small changes in 'time_brightness', by setting it halfway between the 'time_brightness' values for darkest night and first stage of dawn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Night sky: Fix brightness threshold for applying night colours
Previously, 'time_brightness' never fell below the threshold so
night sky colours were not applied.
Increase the threshold value. But now also set it to a value less
sensitive to possible future small changes in 'time_brightness',
by setting it halfway between the 'time_brightness' values for
darkest night and first stage of dawn.
///////////////////////
Fixes #7858
Possibly due to recent changes to the light curve,
time_brightnessis now 0.0753 at night so no longer falls below 0.07, so night sky colours were not applied.Change to
< 0.08f.^ PR
H 215 S 100 V 7
^ MT master
H 210 S 44 V 7
Daytime sky is H 215 S 44 V 98.
So night sky is unchanged in brightness, but now saturation is at maximum for a nice deep blue. Hue now matches daytime sky hue.