Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircleCI config file added #7906

Closed
wants to merge 1 commit into from
Closed

CircleCI config file added #7906

wants to merge 1 commit into from

Conversation

Unarelith
Copy link
Contributor

@Unarelith Unarelith commented Nov 28, 2018 •
edited
Loading

I'm making this PR because #6766 is a "Can't add", but take it as a temporary fix.
I personnally prefer TravisCI so keeping old files and compatibility may be useful if we decide to switch back to it.

But TravisCI delayed their open source projects migration from travis-ci.org to travis-ci.com so I made some research: to fix this issue some open-source projects in a similar situation moved to CircleCI.

The GitHub integration looks like this: travis-ci/travis-ci#5035 (comment)

Since this could be a valid option, I tried to make a config file for it.

List of the tests that currently work:

  • clang-format
  • clang-tidy
  • win32
  • win64
  • osx
  • gcc 6
  • gcc 7
  • clang 3.6
  • clang 5
  • clang 5 without freetype
  • clang 5 with valgrind

OSX free plan has to be asked directly to CircleCI though: cs@circleci.com
https://circleci.com/pricing/#faq-section-os-x

@Unarelith Unarelith force-pushed the circleci branch 4 times, most recently from 167f2c9 to d49440e Compare November 28, 2018 02:14
@paramat paramat added the @ Build CMake, build scripts, official builds, compiler and linker errors label Nov 28, 2018
@Unarelith Unarelith force-pushed the circleci branch 9 times, most recently from e888197 to a2ad70b Compare November 28, 2018 04:13
Unarelith
Unarelith commented Nov 28, 2018
View reviewed changes
lib/jsoncpp/CMakeLists.txt
@@ -1,3 +1,7 @@
if(NOT MSVC)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed for clang tests

@Unarelith Unarelith changed the title CircleCI config file added. [WIP] CircleCI config file added Nov 28, 2018
sfan5
sfan5 reviewed Nov 28, 2018
View reviewed changes
util/circleci/before_install.sh
sed -e "s|%PREFIX%|i686-w64-mingw32|" \
-e "s|%ROOTPATH%|/usr/i686-w64-mingw32|" \
< util/travis/toolchain_mingw.cmake.in > util/buildbot/toolchain_mingw.cmake
sudo 7z x -y -o/usr mingw.7z
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config.yml installs mingw from the repos, so either that or downloading mingw here isn't needed.

Copy link
Contributor Author

@Unarelith Unarelith Nov 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the sed commands are really important, but seems to work without installing p7zip and MinGW in this script though.

EDIT: I was wrong, it doesn't work without this MinGW installation. Looks like it works if I remove it from .circleci/config.yml.

@sfan5
Copy link
Member

sfan5 commented Nov 28, 2018

Can this be seen in action anywhere? As in: build status, build logs, ...

@Unarelith Unarelith force-pushed the circleci branch 2 times, most recently from 37edb0d to 1223630 Compare November 28, 2018 11:30
@Unarelith
Copy link
Contributor Author



@Unarelith Unarelith force-pushed the circleci branch 3 times, most recently from b778717 to a8a29ca Compare November 28, 2018 12:17
@paramat
Copy link
Contributor

paramat commented Nov 29, 2018

I certainly support the concept because this stops Lint marking builds as failed.

@nerzhul
Copy link
Member

nerzhul commented Dec 3, 2018

@paramat you can set a exit 0 after a linter, but remember if linter is ignored the code style is useless and we don't need to use it just remove the task and re-start to check all the code style on all PR :)

@Unarelith
Copy link
Contributor Author

@paramat you can set a exit 0 after a linter, but remember if linter is ignored the code style is useless and we don't need to use it just remove the task and re-start to check all the code style on all PR :)

That's why I made this PR, to separate build and lint, but still keep lint.

@paramat
Copy link
Contributor

paramat commented Dec 3, 2018

nerzhul ok will try that next time.

@rubenwardy rubenwardy requested a review from nerzhul June 20, 2019 23:33
@rubenwardy rubenwardy force-pushed the master branch 2 times, most recently from 0e3b135 to 39c54e1 Compare June 21, 2019 00:46
@nerzhul
Copy link
Member

nerzhul commented Jun 21, 2019

if merged and works totally properly for some days drop travis, please

@nerzhul
Copy link
Member

nerzhul commented Apr 17, 2020

We will switch to Github Actions instead

@nerzhul nerzhul closed this Apr 17, 2020
@dennisjenkins75
Copy link
Contributor

If minetest has any stale circleci keys, you should revoke them anyway (even if not used). https://circleci.com/blog/january-4-2023-security-alert/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 left review comments

@nerzhul nerzhul nerzhul approved these changes

Assignees
No one assigned
Labels
@ Build CMake, build scripts, official builds, compiler and linker errors One approval ✅ ◻️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Unarelith @sfan5 @paramat @nerzhul @dennisjenkins75 @rubenwardy