Hudbars displays twice in 5.0

[rubenwardy]

I wasn't aware of any breaking changes made to health bars and such. When installing hudbars, it no longer hides the health bar

If this is a breaking change, then it needs to be documented
If this is a bug, then it would be nice to have it fixed

[SmallJoker]

Fix1: #7360
Fix2: #7348

Your review is welcome.

[Wuzzy2]

I can confirm the bug.
Whether it is hudbars' fault or Minetest's, I don't know.

[rubenwardy]

It's definitely Minetest's

[paramat]

Apparently fixed by #8167

[paramat]

#8167 merged, this may be fixed now.

[paramat]

Odd, i can't confirm this bug using hudbars v1.11.0 in 33afe1f (before the merge of 8167).

[paramat]

No bug with #8167 merged either.

[paramat]

@rubenwardy @Wuzzy2 please test for the bug now that #8167 is merged.
Apparently this is fixed by #8167 see #8167 (comment)

[Wuzzy2]

Seems to work.
ffb17f1

[Wuzzy2]

Sadly, the healthbar in MCL2 still seems to fail.
The hearts don't turn black when taking damage.
Oddly, the other bars seem to work correctly.
MCL2 also uses hudbars. It also works fine in 0.4.17.1. Weird. :-(

[paramat]

Thanks, hudbars appearing twice is fixed by #8167 then, your other issue (please open a new issue for that) may be fixed by #7360 . However i don't think we can let this MCL2 bug block release, unfortunately, as it is a rare type of usage with easy workarounds.

[paramat]

Hudbars appearing twice is fixed by #8167 , confirmed by me, SmallJoker and Wuzzy2. So closing.
Please open a new issue for "Sadly, the healthbar in MCL2 still seems to fail.
The hearts don't turn black when taking damage." which is not hudbar duplication.

[paramat]

I've made #7360 a blocker for consideration for 5.0.0, as the remaining hudbar bugs may be considered a blocker.

[paramat]

#7360 merged.