New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hudbars displays twice in 5.0 #8075

Closed
rubenwardy opened this Issue Jan 8, 2019 · 14 comments

Comments

Projects
None yet
4 participants
@rubenwardy
Copy link
Member

rubenwardy commented Jan 8, 2019

I wasn't aware of any breaking changes made to health bars and such. When installing hudbars, it no longer hides the health bar

If this is a breaking change, then it needs to be documented
If this is a bug, then it would be nice to have it fixed

@SmallJoker

This comment has been minimized.

Copy link
Member

SmallJoker commented Jan 8, 2019

Fix1: #7360
Fix2: #7348

Your review is welcome.

@Wuzzy2

This comment has been minimized.

Copy link
Contributor

Wuzzy2 commented Jan 9, 2019

I can confirm the bug.
Whether it is hudbars' fault or Minetest's, I don't know.

@rubenwardy

This comment has been minimized.

Copy link
Member Author

rubenwardy commented Jan 9, 2019

It's definitely Minetest's

@paramat

This comment has been minimized.

Copy link
Member

paramat commented Feb 3, 2019

Apparently fixed by #8167

@paramat

This comment has been minimized.

Copy link
Member

paramat commented Feb 10, 2019

#8167 merged, this may be fixed now.

@paramat

This comment has been minimized.

Copy link
Member

paramat commented Feb 10, 2019

Odd, i can't confirm this bug using hudbars v1.11.0 in 33afe1f (before the merge of 8167).

@paramat

This comment has been minimized.

Copy link
Member

paramat commented Feb 10, 2019

No bug with #8167 merged either.

@paramat

This comment has been minimized.

Copy link
Member

paramat commented Feb 11, 2019

@rubenwardy @Wuzzy2 please test for the bug now that #8167 is merged.
Apparently this is fixed by #8167 see #8167 (comment)

@Wuzzy2

This comment has been minimized.

Copy link
Contributor

Wuzzy2 commented Feb 11, 2019

Seems to work.
ffb17f1

@Wuzzy2

This comment has been minimized.

Copy link
Contributor

Wuzzy2 commented Feb 11, 2019

Sadly, the healthbar in MCL2 still seems to fail.
The hearts don't turn black when taking damage.
Oddly, the other bars seem to work correctly.
MCL2 also uses hudbars. It also works fine in 0.4.17.1. Weird. :-(

@paramat

This comment has been minimized.

Copy link
Member

paramat commented Feb 11, 2019

Thanks, hudbars appearing twice is fixed by #8167 then, your other issue (please open a new issue for that) may be fixed by #7360 . However i don't think we can let this MCL2 bug block release, unfortunately, as it is a rare type of usage with easy workarounds.

@paramat paramat closed this Feb 11, 2019

@paramat paramat removed this from Issues in Minetest 5.0.0 Feb 11, 2019

@rubenwardy rubenwardy reopened this Feb 11, 2019

@paramat

This comment has been minimized.

Copy link
Member

paramat commented Feb 11, 2019

Hudbars appearing twice is fixed by #8167 , confirmed by me, SmallJoker and Wuzzy2. So closing.
Please open a new issue for "Sadly, the healthbar in MCL2 still seems to fail.
The hearts don't turn black when taking damage." which is not hudbar duplication.

@paramat paramat closed this Feb 11, 2019

@paramat paramat removed the Blocker label Feb 11, 2019

@paramat paramat removed this from the 5.0.0 milestone Feb 11, 2019

@paramat

This comment has been minimized.

Copy link
Member

paramat commented Feb 11, 2019

I've made #7360 a blocker for consideration for 5.0.0, as the remaining hudbar bugs may be considered a blocker.

@paramat

This comment has been minimized.

Copy link
Member

paramat commented Feb 12, 2019

#7360 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment