Player regains a little breath when rejoining game into ignore

[LoneWolfHT]

Issue type

• Bug report

Minetest version

Minetest 5.0.0-dev-a809f736

OS / Hardware

Operating system: Ubuntu 18.10
CPU: AMD Ryzen 7 2700

Summary

(When the background is grey I've just joined the game)

Steps to reproduce

Leave the game while underwater and half out of breath. Then rejoin and watch your bubble meter. Might need to enable some heavy mods

[Wuzzy2]

Random guess for the reason: Player client first thinks it spawns in ignore before it loaded the liquid, and ignore does not deal drowning damage.

Solution (if my guess is true): Neither increase or decrease the breath meter while player is stuck in ignore.

[SmallJoker]

Following code needs checking against ignore

minetest/src/content_sao.cpp

Lines 1017 to 1021 in ba5a9f2

	MapNode n = m_env->getMap().getNodeNoEx(p);
	const ContentFeatures &c = m_env->getGameDef()->ndef()->get(n);
	// If player is alive & no drowning, breathe
	if (m_hp > 0 && m_breath < m_prop.breath_max && c.drowning == 0)
	setBreath(m_breath + 1);

[paramat]

Grey background means player is in ignore.