-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liquids don't flow in other airlike nodes #828
Comments
Impossible to do. What if you have an airlike node that contains metadata or something like that? Or that is walkable? |
Why would anyone in their right mind do that? Paramat's moonrealm [https://github.com/paramat/moonrealm] has a (tinted) atmosphere, w/ lakes on the surface that can't flow. He also has another airlike node that's generated from the airgen that's stand-in for default air, (the reason this is done is so you dont have to run an ABM on default air). Also, there are residual default air nodes left over when realms are generated, and with the airgen/airspread ABM's running on those as well, it tends to destroy the tinted atmosphere (undesired). This is going to be a problem for anyone that tries to make a space-type mod, especially with survival elements. Perhaps i'm wrong, but I sortof expect airlike nodes to behave the same way, otherwise the drawtype is useless to modders if the only node that behaves like air, is air. I am working on lua workarounds in the meantime, but i'd think you guys would want to do things The Right Way (tm) |
Maybe checking for builable_to would be more appropriate than checking the drawtype. |
IMO it should check airlike and builable_to |
i can make flooding builable_to nodes with liquid_finite=1. airlike is used in original sponge: mod for preventing from flooding area around sponge. |
Well, then... a new parameter in node definition is needed. |
This is a duplicate of #47. Closing. I talked to @celeron55 once and we decided that it should flush everything away that is buildable_to, and drop the node if its not walkable. I already spend some work on this in my fork, though the dropping part is missing: PilzAdam@327ed9e |
lol beat me to it :P found a lua solution to use plain air in realms without ABM meltdown :-) |
Hi PilzAdam, that's good news that in future water may flush away / flow into atmosphere nodes ... however i must request that 'airlike' nodes are not then dropped as this would create large numbers of invisible entites that are unwanted atmosphere nodes ... it would essentially make my realms and atmosphere nodes unusable. Also of course fog and cloud nodes should not be dropped if water flows into them. |
I believe you can use |
what? |
What? |
By that i mean mod generated fog and cloud nodes, for example my slabrealm mod has lua generated clouds. |
Oh, now I understand |
Pretty simple - liquids only flow where there's builtin/default 'air', but not for any other airlike node. ( Im assuming airlike means more than porous, enough to let liquids pass through. )
This affects at least two mods
![screenshot_3684764642](https://camo.githubusercontent.com/871745395195090110c563878cec20e5349341a58ff3e0e05db632f164a69e31/68747470733a2f2f662e636c6f75642e6769746875622e636f6d2f6173736574732f333232383937352f3739343035382f64323764363362302d656336362d313165322d386664302d6564346134613537333562362e706e67)
The text was updated successfully, but these errors were encountered: