-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Game-provided menu music #8596
Comments
(Nobody uses this anyway, as the starting time increases massively.) Imo subgame specific main menu music shouldn't replace the general main menu music. |
But no one uses main menu music, heck I don't think most people even know it exists. If people haven't used general menu music up until this point, I don't see why maintaining compatibility with it is important. |
I didn't know it existed. But I might use it if I knew where to put the music Subgame-specific music is supported too? 😮 |
👍 good issue. As discussed a while ago with RBA who wanted MT engine music (which was a silly idea):
If anyone uses the current folder for music, that should be moved to a game, there are no compatibility issues because mods and games currently can't contain music. So i suggest removing the engine sounds folder. |
Blank minetest does have sort of a "character", there are clouds in the background and a bright blue sky. If it had no character, everything would have to be completely transparent so that you see your dektop background. Also it wouldn't be so nice if it was impossible to set a music for other tabs than singleplayer. |
No games installed but still clouds in the background.
Well, it provides a default background when there are no games available. Why shouldn’t it provide default menu music when there are no games available? |
Some good points. However, i don't agree that the engine can have music, we've gone through this argument before at great length with RBA and it's impossible to choose anything, it's very different to visuals so it can't be paralleled. If there are no games i think there should be no music. |
Not sure if a duplicate of #7867 as that may be for in-game music only. |
People's taste in music is very fussy and individual. Whatever you chose, 50% would dislike it, 45% would be 'meh' and 5% would like it. So there are some things to consider: |
I think that if game-specific music is cut off when switching tabs, that it should fade in and out so as not to cause a sudden change in volume or tone. |
It should be a startup sound (oneshot), not a whole song (loop).
I like the fade in/out suggestion in case it is a loop though.
minetest.fade_sound might work, maybe.
…On Thu, Jun 13, 2019, 8:43 PM Paramat ***@***.***> wrote:
People's taste in music is very fussy and individual. Whatever you chose,
50% would dislike it, 45% would be 'meh' and 5% would like it.
So there are some things to consider:
Which tabs it is played in?
As game content it would be downloaded as you connect to a server, so it
may need to be handled differently.
I'll change the issue title to be more general.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8596?email_source=notifications&email_token=AFS4UYTGIQKSPICSEME5CL3P2LSRVA5CNFSM4HXWAF22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXVM4RA#issuecomment-501927492>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFS4UYV3DY3ICVQP7MQQBILP2LSRVANCNFSM4HXWAF2Q>
.
|
Let's not over complicate this and try to make game-writers have to break and split and make music themselves. Most will be doing well to use premade music for things like this. |
My point is that it doesn't have to be a whole song. It can be a single sound that plays upon the game's selection. (An example is when selecting a title on the 3DS' main menu.)
I don't expect game creators to break and split and make music themselves. It does sound like a fun exercise though, and something a group of game creators could do together. |
I don't really care about music for the menu system... I'm much more concerned about adding clickity, clackity sounds when hitting buttons, etc.. |
Implemented by #11241 |
Issue type
Minetest version
Summary
We have main menu music, but it's for the engine and isn't used. This has been mentioned several times but not put into it's own issue yet afaik.
Relevant code seems to be here
minetest/src/gui/guiEngine.cpp
Line 100 in 6cb6aea
The text was updated successfully, but these errors were encountered: