Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game-provided menu music #8596

Closed
benrob0329 opened this issue Jun 13, 2019 · 15 comments
Closed

Game-provided menu music #8596

benrob0329 opened this issue Jun 13, 2019 · 15 comments
Labels

Comments

@benrob0329
Copy link
Member

Issue type
  • Feature request
Minetest version
5.0.1
Summary

We have main menu music, but it's for the engine and isn't used. This has been mentioned several times but not put into it's own issue yet afaik.

Relevant code seems to be here

/** MenuMusicFetcher */

@Desour
Copy link
Member

Desour commented Jun 13, 2019

(Nobody uses this anyway, as the starting time increases massively.)

Imo subgame specific main menu music shouldn't replace the general main menu music.

@benrob0329
Copy link
Member Author

benrob0329 commented Jun 13, 2019

But no one uses main menu music, heck I don't think most people even know it exists. If people haven't used general menu music up until this point, I don't see why maintaining compatibility with it is important.

@LoneWolfHT
Copy link
Contributor

But no one uses main menu music, heck I don't think most people even know it exists. If people haven't used general menu music up until this point, I don't see why maintaining compatibility with it is important.

I didn't know it existed. But I might use it if I knew where to put the music

Subgame-specific music is supported too? 😮

@paramat paramat added Concept approved Approved by a core dev: PRs welcomed! @ Client / Audiovisuals Sounds labels Jun 13, 2019
@paramat
Copy link
Contributor

paramat commented Jun 13, 2019

👍 good issue.

As discussed a while ago with RBA who wanted MT engine music (which was a silly idea):

The engine cannot have music because all content is provided by games.
Every game requires different music.
The engine cannot have music because it is completely neutral and characterless.
The main menu, rightly, has backgrounds provided by the currently selected game, so should also have music provided the same way.
When MT starts it instantly presents game content (menu backgrounds), there is no time for the engine to present content.
The idea of the engine having music comes from misunderstanding the engine as some sort of game.

If anyone uses the current folder for music, that should be moved to a game, there are no compatibility issues because mods and games currently can't contain music. So i suggest removing the engine sounds folder.

@Desour
Copy link
Member

Desour commented Jun 13, 2019

Blank minetest does have sort of a "character", there are clouds in the background and a bright blue sky. If it had no character, everything would have to be completely transparent so that you see your dektop background. Also it wouldn't be so nice if it was impossible to set a music for other tabs than singleplayer.
Anyway, #7139 should have a much higher priority.
And isn't this a duplicate of #7867?

@ghost
Copy link

ghost commented Jun 13, 2019

When MT starts it instantly presents game content (menu backgrounds), there is no time for the engine to present content.

No games installed but still clouds in the background.

s

The engine cannot have music because it is completely neutral and characterless.

Well, it provides a default background when there are no games available. Why shouldn’t it provide default menu music when there are no games available?

@paramat
Copy link
Contributor

paramat commented Jun 14, 2019

Some good points.
I didn't realise the game menu background doesn't appear in tabs other than 'start game', some of my points are therefore wrong.

However, i don't agree that the engine can have music, we've gone through this argument before at great length with RBA and it's impossible to choose anything, it's very different to visuals so it can't be paralleled. If there are no games i think there should be no music.
So perhaps game music is only played in the 'Start Game'? However i'd also be fine with it being played in all tabs.

@paramat
Copy link
Contributor

paramat commented Jun 14, 2019

Not sure if a duplicate of #7867 as that may be for in-game music only.

@paramat
Copy link
Contributor

paramat commented Jun 14, 2019

People's taste in music is very fussy and individual. Whatever you chose, 50% would dislike it, 45% would be 'meh' and 5% would like it.
For that poor result you would have to bloat the engine by 5MB.
Then imagine the time and arguments over what to choose.
Music is emotional and deeply meaningful for people, that's not suitable for a neutral game engine.
The ability to have engine menu music was a mistake in the first place, it won't be used so should be removed.

So there are some things to consider:
Which tabs it is played in?
As game content it would be downloaded as you connect to a server, so it may need to be handled differently.
I'll change the issue title to be more general.

@paramat paramat changed the title Move Menu Music To $GAMEDIR/menu/sounds Game-provided menu music Jun 14, 2019
@benrob0329
Copy link
Member Author

I think that if game-specific music is cut off when switching tabs, that it should fade in and out so as not to cause a sudden change in volume or tone.

@ghost
Copy link

ghost commented Jun 14, 2019 via email

@benrob0329
Copy link
Member Author

Let's not over complicate this and try to make game-writers have to break and split and make music themselves. Most will be doing well to use premade music for things like this.

@ghost
Copy link

ghost commented Jun 15, 2019

My point is that it doesn't have to be a whole song. It can be a single sound that plays upon the game's selection. (An example is when selecting a title on the 3DS' main menu.)

Let's not over complicate this and try to make game-writers have to break and split and make music themselves.

I don't expect game creators to break and split and make music themselves. It does sound like a fun exercise though, and something a group of game creators could do together.

@TumeniNodes
Copy link

I don't really care about music for the menu system... I'm much more concerned about adding clickity, clackity sounds when hitting buttons, etc..
This to me that is far more important and desired for a menu system.
Music should be focused on for during play (and subtly playing in the background) (just my own opinion)

@rubenwardy
Copy link
Member

Implemented by #11241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants