Unify wield item handling #8677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
added
@ Server / Client / Env.
Maintenance
This moves the wield item functions to Player and the tool utils for range calculation Also 'local_inventory' was removed due to redudancy in Client
SmallJoker
force-pushed
the
fix_wielditem
branch
from
ab5b6f3
to
4743dee
Compare
sfan5
reviewed
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the wield item functions to Player and the tool utils for range calculation
Also 'local_inventory' was removed due to redundancy in Client
Removing this duplicated code reduces the possibility of different handling in server and client.
To do
This PR is Ready for Review.
How to test
Create a
handslot, put a tool or anything else in.Click randomly in your world. If your hand is not capable of digging the node, it will try to fall back to
hand(same as in master).