Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-order mapgens in mainmenu and 'all settings' mapgen selection #8705

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Re-order mapgens in mainmenu and 'all settings' mapgen selection #8705

merged 1 commit into from
Jul 25, 2019

Conversation

paramat
Copy link
Contributor

@paramat paramat commented Jul 22, 2019

Text for each mapgen is still a good idea and will probably be done, but a logical display order in the mapgen selection dropdowns is also useful.
Somewhat attends to #8644

// Order used here defines the order of appearence in mainmenu.
// v6 always last to discourage selection.
// Special mapgens flat, fractal, singlenode, next to last. Of these, singlenode
// last to discourage selection.
// Of the remaining, v5 last due to age, v7 first due to being the default.

New order:

	{"v7",         true},
	{"valleys",    true},
	{"carpathian", true},
	{"v5",         true},
	{"flat",       true},
	{"fractal",    true},
	{"singlenode", true},
	{"v6",         true},

Promotes the newer mapgens Valleys and Carpathian more. The first 3 in the list are the 3 most impressive mapgens.

@paramat paramat added @ Mapgen Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements WIP @ Mainmenu and removed WIP labels Jul 22, 2019
@paramat
Copy link
Contributor Author

paramat commented Jul 25, 2019

Now tested, does not cause problems for existing worlds, mapgen selection works fine.
Ready for merge.

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But people might argue now that these are totally out of order in terms of alphabetic sorting.

@v-rob
Copy link
Member

v-rob commented Jul 25, 2019

I think that v5, v6, and v7 should still be renamed to something else, as do many other people, but I know that is a subject of great contentiousness and I'm not going to press the issue.

This is a good idea, especially since dropdowns shows only 5 options before you have to scroll down, so the five most important are the first ones people see, and if they never scroll down, they won't even notice the more specialized/v6 mapgens.

@srifqi
Copy link
Member

srifqi commented Jul 25, 2019

What about this file?

# Name of map generator to be used when creating a new world.
# Creating a world in the main menu will override this.
# Current mapgens in a highly unstable state:
# - The optional floatlands of v7 (disabled by default).
mg_name (Mapgen name) enum v7 v5,v6,v7,valleys,carpathian,fractal,flat,singlenode

@paramat
Copy link
Contributor Author

paramat commented Jul 25, 2019

Heh, it was already not alphabetical order, and there's no need for that =)

srifqi, thanks, 'all settings' displays a dropdown menu too, will change that.
EDIT: Done.

Screenshot from 2019-07-25 20-36-11

@paramat paramat added the WIP label Jul 25, 2019
v6 always last to discourage selection.
Special mapgens flat, fractal, singlenode, next to last. Of these, singlenode
last to discourage selection.
Of the remaining, v5 last due to age, v7 first due to being the default.
@paramat paramat removed the WIP label Jul 25, 2019
@paramat paramat changed the title Display a logical mapgen order in mainmenu Re-order mapgens in mainmenu and 'all settings' mapgen selection Jul 25, 2019
@paramat paramat merged commit 0cde6fc into minetest:master Jul 25, 2019
@paramat paramat deleted the mgorder branch September 8, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Mainmenu Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements @ Mapgen One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants