Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return empty table when minetest.get_connected_players() is called at load time #9493

Merged
merged 1 commit into from Mar 10, 2020
Merged

Return empty table when minetest.get_connected_players() is called at load time #9493

merged 1 commit into from Mar 10, 2020

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Mar 9, 2020

fixes #9490

@sfan5 sfan5 added @ Script API Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Bugfix 🐛 PRs that fix a bug labels Mar 9, 2020
@sfan5 sfan5 added this to the 5.2.0 milestone Mar 9, 2020
@paramat paramat added the Blocker The issue needs to be addressed before the next release. label Mar 10, 2020
@SmallJoker SmallJoker merged commit 7a7bfdc into minetest:master Mar 10, 2020
@sfan5 sfan5 deleted the lua_connected_players branch March 10, 2020 19:32
aldum pushed a commit to banyamesterseg/minetest that referenced this pull request Apr 16, 2020
@sfan5 @aldum
minetest,get_connected_players: Return empty table at load time (mine…
9ebc246 
…test#9493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
Blocker The issue needs to be addressed before the next release. Bugfix 🐛 PRs that fix a bug One approval ✅ ◻️ @ Script API Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

minetest.get_connected_players should not return nil
3 participants
@sfan5 @SmallJoker @paramat