Add object crosshair and disable entity selectionboxes by default #9523

LoneWolfHT · 2020-03-18T02:03:16Z

Goal of the PR

Add an indicator on the HUD to indicate when you are pointing at an entity. Similar to Minecraft's:

How does the PR work?

Replaces the default crosshair with a X when you are pointing at an entity
Comparison between HUD when pointing/not pointing at an entity:

The object crosshair is pretty much exactly like the regular crosshair in customization, it also uses the crosshair HUD flag to determine appearance

To define a custom texture for it use object_crosshair.png
To define a custom color use the object_crosshair_color setting
To define a custom alpha use the object_crosshair_alpha setting

This also disables entity selectionboxes by default

Does it resolve any reported issue?

Not a reported one, but @tacotexmex has been wanting entity selectionboxes removed for a while now.
Entity selectionboxes break immersion and are better suited for dev work IMO.
This PR will disable them by default without preventing players from knowing when they're pointing at an entity.

To do

This PR is Ready for Review.

How to test

Join the game and put your crosshair over an entity while within range of it (dropped items work well)
Make sure the object_crosshair settings (color/alpha) work
Make sure the crosshair/object_crosshair textures work and work together
Make sure the object crosshair doesn't appear when the HUD flag for the crosshair is disabled

I have tested all of the above without finding anything wrong

paramat · 2020-03-18T23:02:53Z

Nice idea.
Note: Changes to minetest.conf.example are not necessary and are wasted work, as that file is regularly autogenerated from settingtypes.txt.

LoneWolfHT · 2020-03-18T23:49:04Z

Ok thanks. I'll remove that...

tacotexmex · 2020-03-19T11:04:43Z

Nice improvement! 🎉

Is the position of the texture off-center? I’d suggest that it be completely centered and then offsetted in the texture itself. This way makers can choose any position of the indicator by customizing the texture.

LoneWolfHT · 2020-03-19T15:41:13Z

Changed

rubenwardy · 2020-03-19T15:45:16Z

I like this, but I'm concerned about how obvious this would be to the user. The sword like thing in MC looks like an entity health bar?

LoneWolfHT · 2020-03-19T15:49:43Z

The sword is actually on the HUD most of the time, it displays the charge of the wielded tool. The plus icon below it only shows up when pointing at an entity. I guess I could have made it more clear
I think most players will be able to figure out what is going on pretty quickly. Since they'll only notice it when pointing at an entity

tacotexmex · 2020-03-19T16:57:38Z

Come to think of it, why not define this as an alternative crosshair feature altogether? Meaning, not add this indicator on top of the existing crosshair but instead replace it?

LoneWolfHT · 2020-03-19T17:02:51Z

Come to think of it, why not define this as an alternative crosshair feature altogether? Meaning, not add this indicator on top of the existing crosshair but instead replace it?

Replace it with what? Most of the time you should be able to just cover it up, the selectionindicator is drawn after the crosshair is

paramat · 2020-03-19T22:37:35Z

Meaning, not add this indicator on top of the existing crosshair but instead replace it?

Do you mean: the crosshair changes shape when pointing at an entity?

LoneWolfHT · 2020-03-19T22:39:26Z

A setting for replacement could be added I guess

sorcerykid · 2020-03-19T23:58:51Z

I really like the concept :)

But I have a dumb question: How is a selection indicator any less immersion breaking? I'm inclined to think it would be just as intuitive if not moreso if the crosshair simply changed shape to indicate that it's pointing to an entity or player. Having a dot showing the location of the entity almost seems like it would be more distracting than the selection box, esp. if the entity is moving.

Either way, it's still nice change of pace, and I welcome anything that helps to improve the gameplay experience.

LoneWolfHT · 2020-03-20T00:13:07Z

Having a dot showing the location of the entity almost seems like it would be more distracting than the selection box, esp. if the entity is moving.

The dot doesn't show the location of anything, it's just a dot above the crosshair that appears in the same place every time when the player can 'interact with'/'reach' an entity

sorcerykid · 2020-03-20T01:08:45Z

Ah, thanks for the clarification, I was under the impression it was centered on the entity. If it's simply being drawn above the crosshair, then I'm curious why not simply change the crosshair image itself?

LoneWolfHT · 2020-03-20T01:18:04Z

Ah, thanks for the clarification, I was under the impression it was centered on the entity. If it's simply being drawn above the crosshair, then I'm curious why not simply change the crosshair image itself?

What would I change it to? Note: The default isn't an image, it's 2 lines drawn on the screen to form a '+'

src/client/game.cpp

tacotexmex · 2020-03-20T09:50:31Z

Do you mean: the crosshair changes shape when pointing at an entity?

Yes. Regular crosshair would use crosshair.png while the entity crosshair would use crosshair_entity.png or similar. The default look for the indicator can still be the crosshair combined with the dot, but this way it's more versatile imo.

LoneWolfHT · 2020-03-20T16:56:52Z

The selectionindicator texture now replaces the crosshair.
Really need to think up a better name for the selectionindicator...

paramat · 2020-03-21T00:12:11Z

I have a suggestion for the form of the default selection indicator: Instead of a small solid-shaded square, use a small empty box formed by the same lines used to draw the crosshair. So 4 uses of driver->draw2DLine().
This will have more design consistency, be less obstructive to vision because it is not solid-shaded, and because it looks like a box it works like an icon that suggests pointing at the entity's selectionbox.

LoneWolfHT · 2020-03-21T00:21:14Z

I'm not sure it would indicate a selectionbox very well but I'm up for that once someone else comments, the box does seem a little intrusive

sorcerykid · 2020-03-21T11:02:15Z

I was actually going to suggest the exact same thing as paramat, but a diamond shape instead , just to make it even more distinctive. Although a square is perfectly fine by me as well. It's cool that I'm not the only one that was thinking along those same lines (no pun intended :)

tacotexmex · 2020-03-21T12:47:30Z

As long as the look is fully customizable I don’t care about the default look.

LoneWolfHT · 2020-03-21T18:48:27Z

I like the diamond idea, I think I'll do that tonight if nobody has any objections

src/client/game.cpp

Desour · 2020-03-21T20:37:27Z

src/client/hud.cpp

+				m_displaycenter.Y - (size.Y / 2));
+		driver->draw2DImage(selectionindicator, lsize,
+				core::rect<s32>(0, 0, size.X, size.Y),
+				0, selectionindicator_argb, true);


Suggested change

0, selectionindicator_argb, true);

nullptr, selectionindicator_argb, true);

That part is code I copied. Changed both the 'copied' and 'copied from' code

src/client/render/core.cpp

LoneWolfHT · 2020-03-25T00:53:18Z

Also changed indicator to a diamond

Co-authored-by: ANAND <ClobberXD@gmail.com>

Co-authored-by: SmallJoker <SmallJoker@users.noreply.github.com>

LoneWolfHT · 2020-07-10T21:18:23Z

Made all but one of the requested changes and also rebased this so I could run a git diff to make sure I didn't miss anything

SmallJoker · 2020-07-11T09:02:15Z

@LoneWolfHT Thank you for the changes. I'll re-review/retest soon.
Pro tip to avoid most of the rebase hell in the future:
git rebase -i HEAD~20 to squash most (or all) commits prior rebasing -> results in less rebase work and less errors.

sfan5

Tested.

Adds new object crosshair base pack texture

paramat · 2020-07-15T22:04:36Z

The selectionbox that appears around entities when you select them will be DISABLED BY DEFAULT in favour of the object crosshair

This is fine for me too.

SmallJoker added @ Client / Audiovisuals @ Script API Feature ✨ PRs that add or enhance a feature and removed @ Script API labels Mar 18, 2020

nerzhul reviewed Mar 20, 2020

View reviewed changes

src/client/game.cpp Outdated Show resolved Hide resolved

Desour reviewed Mar 21, 2020

View reviewed changes

src/client/game.cpp Outdated Show resolved Hide resolved

Desour reviewed Mar 21, 2020

View reviewed changes

src/client/render/core.cpp Outdated Show resolved Hide resolved

LoneWolfHT and others added 17 commits July 10, 2020 14:13

Remove minetest.conf.example changes

f8bcf33

Remove image offset for the selectionindicator

e29b295

Remove if checks

b54a650

Make selectionindicator texture replace crosshair

d52f7a3

Make requested changes

0d28739

Change selectionindicator to an X

547fca9

The PR is born

c512690

Change size of selectionindicator lines to 8

9f0996c

Rename to 'object crosshair'

1024795

Fix what I somehow broke

5a442e0

Remove something I missed

ee59ffa

Disappear usage of magic numbers

a7c5692

Apply ClobberXD's code style fix

45f360a

Co-authored-by: ANAND <ClobberXD@gmail.com>

Fix indenting in texture_packs.txt

26dadec

Improve texture_packs.txt doc

b773734

Apply SmallJoker's suggestion

22ce158

Co-authored-by: SmallJoker <SmallJoker@users.noreply.github.com>

Make requested changes

98e7407

LoneWolfHT force-pushed the selection-indicator branch from 2c517f2 to 98e7407 Compare July 10, 2020 21:15

rubenwardy approved these changes Jul 11, 2020

View reviewed changes

rubenwardy added the One approval ✅ ◻️ label Jul 11, 2020

sfan5 approved these changes Jul 14, 2020

View reviewed changes

sfan5 added >= Two approvals ✅ ✅ and removed One approval ✅ ◻️ labels Jul 14, 2020

SmallJoker merged commit 94619d8 into minetest:master Jul 14, 2020

LoneWolfHT deleted the selection-indicator branch July 14, 2020 17:13

SmallJoker pushed a commit that referenced this pull request Jul 14, 2020

Add object crosshair, disable entity selectionboxes by default (#9523)

88ffd64

Adds new object crosshair base pack texture

paramat mentioned this pull request Oct 20, 2020

Object crosshair regression #10528

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add object crosshair and disable entity selectionboxes by default #9523

Add object crosshair and disable entity selectionboxes by default #9523

LoneWolfHT commented Mar 18, 2020 •

edited

Loading

paramat commented Mar 18, 2020 •

edited

Loading

LoneWolfHT commented Mar 18, 2020

tacotexmex commented Mar 19, 2020

LoneWolfHT commented Mar 19, 2020

rubenwardy commented Mar 19, 2020

LoneWolfHT commented Mar 19, 2020 •

edited

Loading

tacotexmex commented Mar 19, 2020

LoneWolfHT commented Mar 19, 2020

paramat commented Mar 19, 2020

LoneWolfHT commented Mar 19, 2020

sorcerykid commented Mar 19, 2020

LoneWolfHT commented Mar 20, 2020 •

edited

Loading

sorcerykid commented Mar 20, 2020

LoneWolfHT commented Mar 20, 2020

tacotexmex commented Mar 20, 2020 •

edited

Loading

LoneWolfHT commented Mar 20, 2020

paramat commented Mar 21, 2020

LoneWolfHT commented Mar 21, 2020

sorcerykid commented Mar 21, 2020 •

edited

Loading

tacotexmex commented Mar 21, 2020

LoneWolfHT commented Mar 21, 2020

Desour Mar 21, 2020

LoneWolfHT Mar 25, 2020

LoneWolfHT commented Mar 25, 2020

LoneWolfHT commented Jul 10, 2020

SmallJoker commented Jul 11, 2020 •

edited

Loading

sfan5 left a comment

paramat commented Jul 15, 2020

	0, selectionindicator_argb, true);
	nullptr, selectionindicator_argb, true);

Add object crosshair and disable entity selectionboxes by default #9523

Add object crosshair and disable entity selectionboxes by default #9523

Conversation

LoneWolfHT commented Mar 18, 2020 • edited Loading

Goal of the PR

How does the PR work?

Does it resolve any reported issue?

To do

How to test

paramat commented Mar 18, 2020 • edited Loading

LoneWolfHT commented Mar 18, 2020

tacotexmex commented Mar 19, 2020

LoneWolfHT commented Mar 19, 2020

rubenwardy commented Mar 19, 2020

LoneWolfHT commented Mar 19, 2020 • edited Loading

tacotexmex commented Mar 19, 2020

LoneWolfHT commented Mar 19, 2020

paramat commented Mar 19, 2020

LoneWolfHT commented Mar 19, 2020

sorcerykid commented Mar 19, 2020

LoneWolfHT commented Mar 20, 2020 • edited Loading

sorcerykid commented Mar 20, 2020

LoneWolfHT commented Mar 20, 2020

tacotexmex commented Mar 20, 2020 • edited Loading

LoneWolfHT commented Mar 20, 2020

paramat commented Mar 21, 2020

LoneWolfHT commented Mar 21, 2020

sorcerykid commented Mar 21, 2020 • edited Loading

tacotexmex commented Mar 21, 2020

LoneWolfHT commented Mar 21, 2020

Desour Mar 21, 2020

Choose a reason for hiding this comment

LoneWolfHT Mar 25, 2020

Choose a reason for hiding this comment

LoneWolfHT commented Mar 25, 2020

LoneWolfHT commented Jul 10, 2020

SmallJoker commented Jul 11, 2020 • edited Loading

sfan5 left a comment

Choose a reason for hiding this comment

paramat commented Jul 15, 2020

LoneWolfHT commented Mar 18, 2020 •

edited

Loading

paramat commented Mar 18, 2020 •

edited

Loading

LoneWolfHT commented Mar 19, 2020 •

edited

Loading

LoneWolfHT commented Mar 20, 2020 •

edited

Loading

tacotexmex commented Mar 20, 2020 •

edited

Loading

sorcerykid commented Mar 21, 2020 •

edited

Loading

SmallJoker commented Jul 11, 2020 •

edited

Loading