Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanups #9759

Merged
merged 4 commits into from
Apr 27, 2020
Merged

Various cleanups #9759

merged 4 commits into from
Apr 27, 2020

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Apr 26, 2020

(don't squash)

To do

This PR is a Ready for Review.

How to test

  1. Install latest version of WorldEdit
  2. Run /spawnentity worldedit:pos1
  3. Check that it says "worldedit:pos1" failed to spawn.
    and that ScriptApiBase::objectrefGetOrCreate(): Pushing ObjectRef to removed/deactivated object, this is probably a bug. does NOT appear

@sfan5 sfan5 added @ Script API Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Bugfix 🐛 PRs that fix a bug labels Apr 26, 2020
@nerzhul nerzhul merged commit 515d38a into minetest:master Apr 27, 2020
@sfan5 sfan5 deleted the awawawawawa branch April 27, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️ @ Script API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants