Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtest: Fix missing liquid properties causing crash #9955

Merged
merged 1 commit into from
May 29, 2020

Conversation

Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented May 28, 2020

Fixes #9938.

Missing liquid* properties are added to all nodes with drawtype == "liquid" or drawtype == "liquidflowing".

@sfan5 sfan5 added Bugfix 🐛 PRs that fix a bug @ Devtest Game labels May 28, 2020
@Wuzzy2
Copy link
Contributor Author

Wuzzy2 commented May 29, 2020

Nice, catch, paramat! Oopsie!

@paramat
Copy link
Contributor

paramat commented May 29, 2020

Did not test but trivial change and i trust your testing 👍

@paramat paramat added the Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines label May 29, 2020
@paramat paramat merged commit 51de4ae into minetest:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug @ Devtest Game One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash loading devtest world (Assertion `liquid_type == LIQUID_SOURCE' failed.)
3 participants