New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup ClientLauncher #10160
Cleanup ClientLauncher #10160
Conversation
In file included from .../minetest/src/client/clientlauncher.cpp:33: .../minetest/src/client/clientlauncher.h:55:17: warning: private field 'font' is not used [-Wunused-private-field] gui::IGUIFont *font = nullptr; ^ .../minetest/src/client/game.cpp:879:7: warning: private field 'random_input' is not used [-Wunused-private-field] bool random_input; ^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works.
Is there a way with this cleanup to run a local game with a specific player name? Previous I could use something like: Now I get the error: |
ClientLauncher
handles the client-relevant CLI arguments and main menu information to start a client.This PR now removes duplicated variables and unifies the startup data into a new (inherited) struct. It's still a mess, but I hope this goes into the right direction.
Features:
Fixes #8273 as a side-effect.
To do
This PR is Ready for Review.
How to test
Plus all main menu functions: