Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Thread::kill() and related unittest #10317

Merged
merged 3 commits into from Sep 10, 2020
Merged

Remove Thread::kill() and related unittest #10317

merged 3 commits into from Sep 10, 2020

Commits on Sep 5, 2020

  1. merge Thread::kill() inside Thread::~Thread() 

    The Thread kill() method isn't used outside testThreadKill unit test
and Thread destructor. It could be make private.

The testThreadKill test should be removed: it tests the kill() feature
in a way minetest doesn't use it (kill and restart a thread), specially
because some pthreads implementations on BSD will not allow to lock
again the m_start_finished_mutex which is hold when the thread is
killed.

Closes: #6065
    @semarie
    semarie committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    25a2017 View commit details
    Browse the repository at this point in the history

  2. properly remove kill()

    @semarie
    semarie committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    b55c301 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. remove dead assignements

    @semarie
    semarie committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    4bbb6a9 View commit details
    Browse the repository at this point in the history