New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MainMenu] Add clear button and icon for search one. #10363
[MainMenu] Add clear button and icon for search one. #10363
Conversation
I assume the 'clear' and 'search' icons are taken from MTG creative mod? Lines 22 to 25 in 4ba5046
EDIT: Done. |
May anybody please review quickly prior to merging? It doesn't take much time surely as this PR is |
I’d prefer search-erase-refresh order, more like the creative inventory. Tooltips would be nice too. |
I think the clear button yet should be first as this is common for the most of graphic interfaces. I'm unsure about tooltips, I think the icons on the buttons are already intuitively understandable what their buttons implement. |
The PR is ready and already reviewed by one core dev. So, merge? |
What is a current status of my PR? It is very easy and has been hanging out in an undefinitive state already two months. No feedback from the core devs up-to-day. Is it approved? If yes, may it be merged now? |
The broken indentation could be seen in the lua_lint run too: https://github.com/minetest/minetest/pull/10363/checks?check_run_id=1474999370#step:5:71 |
@sfan5: I`ve fixed all what was necessary: added actual tabs in my editor and removed the whitespaces. May it be merged now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works
Thanks. :) |
This PR allows to purge the user's search results immediately like as in the creative inventory by just pressing the new 'Clear' button. Also, this adds an icon for the current search button, instead the text. It modifies 'Online' tab and the package manager.
'Online' tab:
Package Manager:
To do
This PR is Ready for Review.