Disable clang-format, clean up scripts #10863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
approved these changes
Jan 24, 2021
sfan5
added
Maintenance
lhofhansl
reviewed
Feb 9, 2021
| perform_lint | ||
| env: | ||
| CLANG_FORMAT: clang-format-9 | ||
| # clang_format: |
There was a problem hiding this comment.
So it's easier to add back I assume, but git revert can also do that so it could as well be removed entirely.
SmallJoker
approved these changes
Feb 26, 2021
|
time to review all coding errors, arf :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration has been completely broken for a long time.
This PR disables clang-format from the CI