New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add mapgen diamond-square #11216
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
added
@ Mapgen
Feature ✨
PRs that add or enhance a feature
WIP
The PR is still being worked on by its author and not ready yet.
labels
Apr 20, 2021
sfan5
reviewed
Apr 21, 2021
PseudoRandom *prandom; | ||
public: | ||
MountainLandscape(PseudoRandom *prandom) {this->prandom = prandom;} | ||
std::list<std::tuple<DiamondSquareMountain *, std::pair<double, double>>> mountains; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small bit of advice: We have a core::vector2d<double>
type you could use here,
perhaps core::vector2d<float>
(short v2f
) would also suffice.
This mapgen cannot generate good plains |
wow... |
Closing as WIP with no progress. Also, is not on the roadmap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature ✨
PRs that add or enhance a feature
@ Mapgen
Possible close
WIP
The PR is still being worked on by its author and not ready yet.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate beatiful mountains using diamond-square algorythm: #11213
This PR is a Work in Progress