Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUIScrollbar: Add styling #11345

Closed
wants to merge 1 commit into from
Closed

GUIScrollbar: Add styling #11345

wants to merge 1 commit into from

Conversation

kilbith
Copy link
Contributor

@kilbith kilbith commented Jun 14, 2021

This PR adds different styling to the scrollbar element.

This is still WIP, lots of styling properties are missing.

Capture d’écran du 2021-06-14 06-00-11

style[scrbar_inv;bgimg=scrbar_bg.png;up_arrow_bgimg=default_mese_crystal.png;down_arrow_bgimg=default_diamond.png;thumb_bgimg=trump.png]

@v-rob Thoughts?

@kilbith kilbith marked this pull request as draft June 14, 2021 04:23
@v-rob
Copy link
Member

v-rob commented Jun 14, 2021

Looks pretty good. From a quick look at the code, it appears that it support state styling, right?

I still wonder if it wouldn't be better for styling parts of elements to be done with something analogous to CSS pseudo elements selectors. It would be nice if scrollbars were actually made of buttons visible to formspecs since it would make styling easier, but it's not much use wishing for the impossible.

(And, those are some... interesting scrollbars. I trust you have better actual styling for i3 :P)

@appgurueu
Copy link
Contributor

Looks nice. I think the black arrows are unneeded if we can provide arbitrary arrow images.

@v-rob
Copy link
Member

v-rob commented Jun 14, 2021

I would assume the black arrows would be replaced by fgimg, not bgimg.

@AFCMS
Copy link
Contributor

AFCMS commented Jun 14, 2021

👍 I am really awaiting this feature!

@v-rob

This comment has been minimized.

@AFCMS

This comment has been minimized.

@sfan5 sfan5 added Feature ✨ PRs that add or enhance a feature Formspec labels Jun 15, 2021
@hlqkj

This comment has been minimized.

@kilbith

This comment has been minimized.

@hlqkj

This comment has been minimized.

@v-rob

This comment has been minimized.

@rubenwardy rubenwardy added the Roadmap The change matches an item on the current roadmap. label Jun 16, 2021
@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Jun 21, 2021

This needs documentation in lua_api.txt.

@rubenwardy
Copy link
Member

This is still WIP, lots of styling properties are missing.

It's fine for this to be merged with only partial styling support, as long as it supports the bare minimum: hover/down states and images for the thumbs and track. More can be added later, this is long overdue

@kilbith kilbith closed this Sep 21, 2021
@AFCMS
Copy link
Contributor

AFCMS commented Sep 21, 2021

@kilbith Why did you close this pr?? It looked to cool!

@kilbith
Copy link
Contributor Author

kilbith commented Sep 27, 2021

Shit project isn't worth my time and my talent until @hecktest comes back.

@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Sep 29, 2021

May I take over this PR?

@appgurueu
Copy link
Contributor

appgurueu commented Oct 12, 2021

Bildschirmfoto von 2021-10-12 19-51-34
I could really use the bgimg (for a color picker). For now I'll have to put the gradient below the scrollbar.

@kilbith
Copy link
Contributor Author

kilbith commented Nov 18, 2021

@Wuzzy2 Feel free to take it over, yes. I intent to work on inventory list styling.

@rubenwardy rubenwardy added the Adoption needed The pull request needs someone to adopt it. Adoption welcomed! label May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adoption needed The pull request needs someone to adopt it. Adoption welcomed! Feature ✨ PRs that add or enhance a feature Formspec Roadmap The change matches an item on the current roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants