Add joystick layout for DragonRise GameCube controller #11467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds controller layout profile for the DragonRise GameCube controller. Followed the xbox controller introduction as a template #5506.
Relates to #4153 and should help anyone with the same controller.
Since it appears DragonRise uses the same vendor/product ID for all their handsets and just wires the controller differently, the product name for my handset is
DragonRise Inc. Generic USB Joystick
. Since they make other controllers which I do not own and cannot test, I don't think using this to autodetect the profile is wise. I've set the layout name (joystick_type
) todragonrise_gamecube
which will not match automatically this controller, but shouldn't erroneously match any other controllers. Users with this controller will have to manually set thejoystick_type
. Obviously this could get out of hand quickly with everyone adding their own joysticks in the code, but considering this is only the second I think it's probably OK for now (of course, I'm new here).To do
Ready for Review.
How to test
Buy yourself a DragonRise GameCube controller or find a way to emulate one 😉, manually enable the profile and try playing the game.