Add embedded PNG texture modifier

[hecktest]

This PR builds upon #11485 by adding a texture modifier called [png: which allows you to send ephemeral textures to clients in the form of base64 PNG binaries. You can use it for captchas, signs and all sorts of other procedural fun.

How to test

Follow the instructions in doc/lua_api.txt, or check out the new devtest nodes:

testnodes:generated_png_emb
testnodes:generated_png_src_emb
testnodes:generated_png_dst_emb

Ready for review.

[celeron55]

Looks good

[hecktest]

@celeron55 Then approve :o

[hecktest]

Reauthored correctly as requested.

[Emojigit]

Looks good! afaik that allows custom player texture since this does not require new images in the filesystem, since Minetest disallows adding extra media during client runtime. Ping @Wuzzy2 , he is the MCL2 main contributor, I think this can resolve the custom skin problem of MCL2.

[Wuzzy2]

I'm no longer active in MCL2 and other developers took over but nice try. :P

[Emojigit]

Will this requires client-side changes? If yes, how to get the client's version?

[sfan5]

Looks good, CI tests this already.

please look at the review comment though

[kilbith]

5.5 milestone please.

[Emojigit]

What will older clients do when they received a png modifier? hecks ***@***.***> 於 2021年7月30日週五 上午3:25 寫道：

…

This PR builds upon #11485 <#11485> by adding a texture modifier called [png: which allows you to send ephemeral textures to clients in the form of base64 PNG binaries. You can use it for captchas, signs and all sorts of other procedural fun. [image: mandels] <https://user-images.githubusercontent.com/42101236/127553321-6857d615-db72-4576-b2f8-5ba3160d95ce.png> How to test Follow the instructions in doc/lua_api.txt, or check out the new devtest nodes: testnodes:generated_png_emb testnodes:generated_png_src_emb testnodes:generated_png_dst_emb Ready for review. ------------------------------ You can view, comment on, or merge this pull request online at: #11498 Commit Summary - Add embedded PNG texture modifier File Changes - *M* doc/lua_api.txt <https://github.com/minetest/minetest/pull/11498/files#diff-da915d7065166fede89169efbfe67ec7016a1458fa6a553443039f2f1ef7a779> (15) - *M* games/devtest/mods/testnodes/textures.lua <https://github.com/minetest/minetest/pull/11498/files#diff-9bf95d978d440fd4f393d3f6debd5d40dc3fd700cab007d4aa6fed7b8d09a969> (31) - *M* src/client/tile.cpp <https://github.com/minetest/minetest/pull/11498/files#diff-955e227b6f551c421062f9038477a5f8d4cedf669d96bcefd22e83df5f451df0> (119) Patch Links: - https://github.com/minetest/minetest/pull/11498.patch - https://github.com/minetest/minetest/pull/11498.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#11498>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANDWAP47KHBTS5KONACLS63T2GTJNANCNFSM5BHDCRMA> .

[NathanSalapat]

I would expect the client to show an unknown texture error and use a random color. Much as happens now it you forget to include a texture, or have a typo in the texture name.

[appgurueu]

I would expect the client to show an unknown texture error and use a random color. Much as happens now it you forget to include a texture, or have a typo in the texture name.

Plus a "generateImage()" error, "unknown texture modifier" or something.

[sfan5]

I will apply the suggested doc change and merge this soon for 5.5 unless anyone has any complaints.