Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mainmenu: Priorize non-modpack mod for "enabled" status colorization #11553

Closed
wants to merge 1 commit into from
Closed

Mainmenu: Priorize non-modpack mod for "enabled" status colorization #11553

wants to merge 1 commit into from

Conversation

snowyu
Copy link
Contributor

@snowyu snowyu commented Aug 18, 2021

Add compact, short information about your PR for easier understanding:

To do

This PR is Ready for Review.

How to test

See issue #11552

@Emojigit
Copy link
Contributor

Emojigit commented Aug 19, 2021 •
edited

Close #11552 (try to link them) Failed

@sfan5 sfan5 added @ Mainmenu Bugfix 🐛 PRs that fix a bug labels Aug 21, 2021
@sfan5 sfan5 linked an issue Aug 21, 2021 that may be closed by this pull request
mainmenu dlg_config_world.lua can not show enabled unified_inventory mod #11552
Closed
@SmallJoker SmallJoker changed the title fix(mainmenu): Cannot display the mod has been enabled If this mod is available in both global mods and modpack. fixed: #11552 Mainmenu: Priorize non-modpack mod for "enabled" status colorization Sep 30, 2021
@SmallJoker
Copy link
Member

Did you check whether this PR now highlights the mod which is used by Minetest? The mod loading order for conflicting names is not defined anywhere, and might be based on alphabetical sorting rather than modpack vs normal installation.

@snowyu
Copy link
Contributor Author

snowyu commented Oct 1, 2021

Yes, I've checked the case. I assume that the algorithm of preparemodlist is roughly correct. It just does not check whether the mod comes from modpack or global. Do you think it is caused by a wrong sorting algorithm in preparemodlist?

@SmallJoker
Copy link
Member

It just does not check whether the mod comes from modpack or global

Yes there's no way of knowing without using the actual C++ functions for that. This PR only makes sense if the "global" mod is used, rather than the modpack one. Otherwise it would be misleading information.

@snowyu
Copy link
Contributor Author

snowyu commented Oct 6, 2021

So, I think the right way should be to export the c++ function as lua api.

@loffren174 loffren174 mentioned this pull request Oct 24, 2021
Closed
@rubenwardy

This comment has been minimized.

Sign in to view
@rubenwardy rubenwardy closed this Jan 28, 2022
@rubenwardy rubenwardy reopened this Jan 28, 2022
@rubenwardy rubenwardy added the Rebase needed The PR needs to be rebased by its author. label Jan 30, 2022
@Zughy Zughy closed this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug @ Mainmenu Rebase needed The PR needs to be rebased by its author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mainmenu dlg_config_world.lua can not show enabled unified_inventory mod
6 participants
@snowyu @Emojigit @SmallJoker @rubenwardy @sfan5 @Zughy