Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add text tile modifier #12084

Closed
wants to merge 1 commit into from

Conversation

jingkaimori
Copy link

Add compact, short information about your PR for easier understanding:
Add text modifier for texture file.

  • Goal of the PR
    Current implemention can render only one character like this:
    image with one character rendered
    Another option is render characters in a string, but this method will render misaligned text because of lacking api.
    image with one character rendered
  • How does the PR work?
  • Does it resolve any reported issue?
  • Does this relate to a goal in the roadmap?
    not yet
  • If not a bug fix, why is this PR needed? What using cases does it solve?
    Improve fps by render text directly instead of overlay dynamicly

To do

This PR is a Work in Progress.

  • Avoid scatter of glyph
  • Render paragraph of texts properly

How to test

See games/devtest/mods/testnodes/textures.lua

@tenplus1
Copy link
Contributor

This feature has been needed for some time now. Will it only work for registered nodes or can we edit the texture on the fly for things like signs ?

@jingkaimori
Copy link
Author

jingkaimori commented Feb 19, 2022

Will it only work for registered nodes or can we edit the texture on the fly for things like signs

Only works for registered nodes, because this PR adds a tile modifier, and tile can be define only in nodedef.

@rubenwardy rubenwardy added @ Client / Audiovisuals Feature ✨ PRs that add or enhance a feature Roadmap: Needs approval The change is not part of the current roadmap and needs to be approved by coredevs beforehand. labels Feb 23, 2022
@rubenwardy
Copy link
Member

This doesn't solve #1367 at all, as it's not a proper way of displaying text on a node
I'd much rather see #9999 picked up for that

@rubenwardy rubenwardy added the WIP The PR is still being worked on by its author and not ready yet. label Feb 23, 2022
@sfan5
Copy link
Member

sfan5 commented Apr 10, 2022

Closed since no progress and this is considered the wrong approach as laid out in @rubenwardy's comment.

@sfan5 sfan5 closed this Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Client / Audiovisuals Feature ✨ PRs that add or enhance a feature Roadmap: Needs approval The change is not part of the current roadmap and needs to be approved by coredevs beforehand. WIP The PR is still being worked on by its author and not ready yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants