Check hp_max > 0 for entities #12667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
force-pushed
the
check-ent-proto
branch
from
696f8bf
to
de8740a
Compare
|
Edit: nevermind, this is another side effect of 303329f. |
sfan5
approved these changes
Aug 13, 2022
rubenwardy
approved these changes
Aug 13, 2022
rubenwardy
added
>= Two approvals ✅ ✅
One approval ✅ ◻️
and removed
One approval ✅ ◻️
>= Two approvals ✅ ✅
labels
sfan5
pushed a commit
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 5.6.0, a zero max HP leads to entities being deactivated even before on_activate is called (i.e. entities are "gone" immediately even before they are added because they are initialized with 0 HP). This is a massive footgun for modders, which somehow have awesome ideas like using
hp_max = 0.5. This PR adds basic validation forhp_max > 0whenever properties are set.