Implement --debugger option to improve UX when debugging crashes #13157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
added
@ Startup / Config / Util
WIP
X64X2
approved these changes
Jan 20, 2023
|
I didn't test but I did read through the code and the code looks good. And it seems like a nice feature. |
celeron55
approved these changes
Jan 20, 2023
sfan5
force-pushed
the
debugger
branch
2 times, most recently
from
dcde792
to
b30226d
Compare
sfan5
removed
the
WIP
TurkeyMcMac
reviewed
Jan 22, 2023
TurkeyMcMac
approved these changes
Jan 22, 2023
LizzyFleckenstein03
pushed a commit
to LizzyFleckenstein03/minetest
that referenced
this pull request
Mar 7, 2023
appgurueu
pushed a commit
to appgurueu/minetest
that referenced
this pull request
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to direct users to enter the magic words to start gdb and then pull out a backtrace with this PR we can just tell them to add a single argument.
This is so seamless that you could even add it to your startup script and have e.g. the server always run under gdb.
To do
This PR is a Work in Progress
How to test
./bin/minetest --debuggeroptionally add a segfault bug somewhere first to see what happens