Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no squash] Drop ENABLE_GLES #13280

Merged
merged 2 commits into from Apr 8, 2023
Merged

[no squash] Drop ENABLE_GLES #13280

merged 2 commits into from Apr 8, 2023

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Mar 5, 2023 •
edited

  • MenuTextureSource changed to better delete textures
  • near_plane setting removed
  • video_driver chosen at runtime, default value is now ""

closes #13257

To do

This PR is Ready for Review.

How to test

  • compile & run Minetest with OpenGL
  • compile & run Minetest with OpenGL ES 2
  • run Minetest on Android

@sfan5 sfan5 added Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements @ Client rendering labels Mar 5, 2023
@sfan5 sfan5 mentioned this pull request Mar 5, 2023
Merged
@numberZero
Copy link
Contributor

See also #13284 for video driver autoselect

numberZero
numberZero reviewed Mar 5, 2023
View reviewed changes
Copy link
Contributor

@numberZero numberZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except near_plane is still in settingtypes.txt

@sfan5
Drop ENABLE_GLES option
4e8d220 
ENABLE_GLES predates forking Irrlicht. Its primary use was to distinguish Irrlicht-ogles from upstream version as Minetest could be compiled with either.
That's not necessary anymore and gets in the way sometimes.
@sfan5
Copy link
Member Author

sfan5 commented Mar 6, 2023

Good catch.

@sfan5 sfan5 added this to the 5.8.0 milestone Mar 10, 2023
This was referenced Mar 13, 2023
Merged
Merged
@Desour
Copy link
Member

Desour commented Apr 7, 2023

There could be a separate compile option for allowing the near_plane setting.
But idk if we need the setting. It probably makes sense for low bit-depth depth buffers, I guess. But it makes cheating easier.
It would be good to have some rationale for why the setting is completely removed.

@sfan5
Copy link
Member Author

sfan5 commented Apr 8, 2023

The rationale is that it never really made much sense and is now more work to keep than to remove.

@sfan5 sfan5 merged commit 9d736e8 into minetest:master Apr 8, 2023
15 checks passed
@sfan5 sfan5 deleted the noenablegles branch April 8, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numberZero numberZero numberZero left review comments

Assignees
No one assigned
Labels
@ Client rendering Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.

Drop ENABLE_GLES
3 participants
@sfan5 @numberZero @Desour