Builtin cleanup, part 1 (game).

[kaeza]

This does several things:

• Breaks lines so each has an absolute maximum of 120 characters (tabs are taken as 4 spaces).
• Fixes some variables being leaked to the global environment (Green Peace would be proud).
• Optimizes some constructs.
• Fixes some small(ish) bugs.
• Most importantly: gets rid of features deprecated long ago.

[rubenwardy]

This all looks good. +1

[ShadowNinja]

Our official line length limit is 90 characters, and tabs are officially 8-space width.
Also, do_nodeupdate is pointless, you can just use nodeupdate directly (or so it seems...).
This will conflict with #1129, but looks good.

[sapier]

tab width is not specified ;-) can this be rebased to 0.4.10?

[ShadowNinja]

This can be moved above so that the tables are generated only on init. Or you can put the pos in here and avoid creating a separate table below. I'd use the first option though because it can be short-circuited.

Also, is there a reason that (0, 0, 0) isn't tried?

[kaeza]

Ah good catch!

I'll move the table outside of the function.

I see no reason why it doesn't try (0, 0, 0) first. Guess it was a small mistake on part of the implementor.

[kaeza]

Will redo it later bit by bit.