Add dev stage to docker image #13573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsor4035
added
@ Build
|
The dev stage works and the test segfault is unrelated to these changes. I've marked it Ready for Review. |
sfan5
reviewed
Jun 10, 2023
JosiahWI
force-pushed
the
feat/dev-containers
branch
from
5e93c2e
to
9ac475b
Compare
rubenwardy
approved these changes
Jul 30, 2023
This allows us to use development containers, which have the advantage of not requiring any tools or libraries to be installed on the host system besides git and docker. Closes minetest#13571
rubenwardy
force-pushed
the
feat/dev-containers
branch
from
9ac475b
to
0a39546
Compare
Wuzzy2
pushed a commit
to Wuzzy2/minetest
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use development containers, which have the advantage of not requiring any tools or libraries to be installed on the host system besides git and docker.
Closes #13571
The testIPv6Socket test is failing with an unhandled exception because my docker container doesn't have ipv6 enabled. I have taken a look at it, and I will try to reproduce something similar in the test and fix it to handle the failure gracefully.