-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO SQUASH] Meshgen tests #13616
[NO SQUASH] Meshgen tests #13616
Conversation
Take a look at non-test code changes here, please. Some changes are necessary for testability (since full |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@numberZero rebase needed |
For a draft? |
I thought it was kind of ready due to the sfan5's "lgtm", my bad |
Ready for review. There are only a few tests included; more should follow in other PRs. E.g. for facedir, raillike, connected nodeboxes... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me. The added unittests pass.
Added a short description for test_mesh_compare.cpp to understand what it does and squashed the commit into "Add mesh comparison functions, for tests".
Add compact, short information about your PR for easier understanding:
Client
, to allow testingTo do
This PR is Ready for Review
How to test