Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO SQUASH] Meshgen tests #13616

Merged
merged 4 commits into from
Feb 22, 2024
Merged

[NO SQUASH] Meshgen tests #13616

merged 4 commits into from
Feb 22, 2024

Conversation

numberZero
Copy link
Contributor

@numberZero numberZero commented Jun 20, 2023

Add compact, short information about your PR for easier understanding:

  • Goal of the PR
    • Meshgen testability.
  • How does the PR work?
    1. Decouple meshgen from Client, to allow testing
    2. Add mesh comparison functions
    3. Add some basic meshgen tests using those
  • Does it resolve any reported issue?
    • No.
  • Does this relate to a goal in the roadmap?
    • Yes, 2.2 Internal code refactoring
  • If not a bug fix, why is this PR needed? What usecases does it solve?

To do

This PR is Ready for Review

How to test

  • Run Minetest (any game), make sure the nodes are still rendered
  • Run unit tests

@numberZero
Copy link
Contributor Author

Take a look at non-test code changes here, please. Some changes are necessary for testability (since full Client is not mockable at all) but there may be other ways.

@wsor4035 wsor4035 added Feature ✨ PRs that add or enhance a feature Code quality labels Jun 20, 2023
@Zughy Zughy added the Roadmap The change matches an item on the current roadmap. label Jun 20, 2023
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/client/mesh_generator_thread.cpp Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
@sfan5 sfan5 added the Rebase needed The PR needs to be rebased by its author. label Oct 2, 2023
@Zughy
Copy link
Member

Zughy commented Oct 2, 2023

@numberZero rebase needed

@numberZero
Copy link
Contributor Author

@numberZero rebase needed

For a draft?

@Zughy
Copy link
Member

Zughy commented Oct 2, 2023

I thought it was kind of ready due to the sfan5's "lgtm", my bad

@numberZero numberZero marked this pull request as ready for review December 17, 2023 15:43
@numberZero
Copy link
Contributor Author

Ready for review.

There are only a few tests included; more should follow in other PRs. E.g. for facedir, raillike, connected nodeboxes...

@sfan5 sfan5 removed the Rebase needed The PR needs to be rebased by its author. label Dec 17, 2023
@sfan5 sfan5 self-requested a review December 17, 2023 16:02
@SmallJoker SmallJoker changed the title Meshgen tests [MANUAL SQUASH] Meshgen tests Feb 14, 2024
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. The added unittests pass.

Added a short description for test_mesh_compare.cpp to understand what it does and squashed the commit into "Add mesh comparison functions, for tests".

@SmallJoker SmallJoker changed the title [MANUAL SQUASH] Meshgen tests [NO SQUASH] Meshgen tests Feb 14, 2024
@rubenwardy rubenwardy merged commit 0d30a30 into minetest:master Feb 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code quality Feature ✨ PRs that add or enhance a feature Roadmap The change matches an item on the current roadmap. >= Two approvals ✅ ✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants