Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler errors on MSVC with ENABLE_TOUCH=TRUE #13625

Merged
merged 1 commit into from Jun 24, 2023

Conversation

grorp
Copy link
Member

@grorp grorp commented Jun 24, 2023

Minetest currently doesn't compile with -DENABLE_TOUCH=TRUE on Windows due to these compiler errors:

C:\mtbuild\minetest-grorp-nonbroken\src\gui\touchscreengui.cpp(43,1): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax [C:\mtbuild\minetest-grorp-nonbroken-built\src\minetest.vcxproj]
C:\mtbuild\minetest-grorp-nonbroken\src\gui\touchscreengui.cpp(49,1): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax [C:\mtbuild\minetest-grorp-nonbroken-built\src\minetest.vcxproj]

This PR fixes these compiler errors.

To do

This PR is a Ready for Review.

How to test

Verify that you can compile Minetest with -DENABLE_TOUCH=TRUE on Windows.

@SmallJoker SmallJoker added @ Build CMake, build scripts, official builds, compiler and linker errors Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Bugfix 🐛 PRs that fix a bug labels Jun 24, 2023
@grorp
Copy link
Member Author

grorp commented Jun 24, 2023

Sadly, the touchscreen GUI doesn't actually work for me on Windows, neither with USE_SDL2=TRUE nor without. It does work on Linux, however.

But at least it compiles now :)

@sfan5 sfan5 merged commit 7e51e2d into minetest:master Jun 24, 2023
11 of 13 checks passed
@grorp grorp deleted the fix-msvc-enable-touch branch December 18, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug @ Build CMake, build scripts, official builds, compiler and linker errors Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants