Fix local animations not resetting #13638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts `LocalPlayerAnimation` to a scoped enum to prevent such bugs in the future
appgurueu
commented
Jun 30, 2023
| @@ -1504,7 +1505,7 @@ void Client::handleCommand_LocalPlayerAnimations(NetworkPacket* pkt) | |||
| *pkt >> player->local_animations[3]; | |||
| *pkt >> player->local_animation_speed; | |||
|
|
|||
| player->last_animation = -1; | |||
There was a problem hiding this comment.
This is the crucial change. If this change is fine, the PR is fine. The rest is just conversion to scoped enum.
|
any idea when this bug was added? |
sfan5
added
Trivial
sfan5
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts
LocalPlayerAnimationto a scoped enum to prevent such bugs in the futureSeems to fix minetest/minetest_game#3042
Caveat: I can't confirm that the
-1was indeed intended to beNO_ANIM, but this makes sense and works fine in testing