New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings GUI: Hide advanced settings by default #13730
Conversation
64a60a0
to
4618ef2
Compare
The PR works but I think it would be good to have an indicator which categories that are "advanced". This is especially important for instructing players (wiki, chat). Suggestion: darker background of active and inactive states. EDIT: Also restore the scrollbar value when ticking the checkbox. Currently it goes back to the top which is rather annoying. |
# | ||
# Requires: show_advanced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very repetitive, especially for mapgens. Would it be much of an effort to add this functionality to entire categories which then propagates the flags to all its contained settings?
I think this ambiguity is quite confusing. I would prefer it if all advanced settings were moved to the "Advanced" and "Mapgen" categories. Toggling the "Show advanced settings" checkbox would then only toggle the visibility of these two top-level categories. |
I'll make a new PR that hides page (IE: mapgen and advanced) rather than individual settings |
Part of #13476
Adds a new checkbox to show/hide advanced settings, hidden by default. By hiding advanced settings, the settings GUI is less overwhelming.
To do
This PR is Ready for Review.
Questions:
How to test