Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings GUI: Hide advanced settings by default #13730

Closed
wants to merge 1 commit into from

Conversation

rubenwardy
Copy link
Member

@rubenwardy rubenwardy commented Aug 12, 2023

Part of #13476

Adds a new checkbox to show/hide advanced settings, hidden by default. By hiding advanced settings, the settings GUI is less overwhelming.

image

To do

This PR is Ready for Review.

Questions:

  • Resolve the ambiguity between different types of advanced settings (there's both an "Advanced" section and the advanced checkbox now)
  • Finalise which settings are considered advanced

How to test

  • Run MT, open settings
  • Toggle show advanced settings dialog, look at settings
  • See all settings marked as advanced in settingtypes.txt

@rubenwardy rubenwardy added @ Startup / Config / Util WIP The PR is still being worked on by its author and not ready yet. Feature ✨ PRs that add or enhance a feature @ Mainmenu labels Aug 12, 2023
@rubenwardy rubenwardy changed the title Settings GUI: Improve advanced settings behaviour Settings GUI: Checkbox to show/hide advanced settings Aug 12, 2023
@rubenwardy rubenwardy mentioned this pull request Aug 5, 2023
17 tasks
@rubenwardy rubenwardy changed the title Settings GUI: Checkbox to show/hide advanced settings Settings GUI: Hide advanced settings by default Aug 12, 2023
@rubenwardy rubenwardy added this to the 5.8.0 milestone Aug 12, 2023
@rubenwardy rubenwardy marked this pull request as ready for review August 12, 2023 22:06
@rubenwardy rubenwardy removed the WIP The PR is still being worked on by its author and not ready yet. label Aug 12, 2023
@SmallJoker
Copy link
Member

SmallJoker commented Aug 13, 2023

The PR works but I think it would be good to have an indicator which categories that are "advanced". This is especially important for instructing players (wiki, chat). Suggestion: darker background of active and inactive states.

EDIT: Also restore the scrollbar value when ticking the checkbox. Currently it goes back to the top which is rather annoying.

Comment on lines +1157 to +1158
#
# Requires: show_advanced
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very repetitive, especially for mapgens. Would it be much of an effort to add this functionality to entire categories which then propagates the flags to all its contained settings?

@grorp
Copy link
Member

grorp commented Aug 30, 2023

Resolve the ambiguity between different types of advanced settings (there's both an "Advanced" section and the advanced checkbox now)

I think this ambiguity is quite confusing. I would prefer it if all advanced settings were moved to the "Advanced" and "Mapgen" categories. Toggling the "Show advanced settings" checkbox would then only toggle the visibility of these two top-level categories.

@rubenwardy rubenwardy closed this Sep 10, 2023
@rubenwardy
Copy link
Member Author

I'll make a new PR that hides page (IE: mapgen and advanced) rather than individual settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants