Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small setting-related fixes #13755

Merged
merged 5 commits into from Aug 27, 2023
Merged

Small setting-related fixes #13755

merged 5 commits into from Aug 27, 2023

Conversation

grorp
Copy link
Member

@grorp grorp commented Aug 24, 2023

This PR contains some small setting-related fixes:

  • It corrects the default value of the fsaa setting in defaultsettings.cpp. The default value of that setting was changed by Add antialiasing filters (FXAA, SSAA) #13253, but the change was only applied to settingtypes.txt.

  • It hides the cinematic_camera_smoothing setting on ENABLE_TOUCH builds, as cinematic mode is not available there.

  • It makes the mouse_sensitivity setting visible again on ENABLE_TOUCH builds, as it also affects "finger sensitivity":

    // adapt to similar behavior as pc screen
    const double d = g_settings->getFloat("mouse_sensitivity", 0.001f, 10.0f) * 3.0f;

To do

This PR is a Ready for Review.

How to test

Look at the settings menu.

@rubenwardy
Copy link
Member

rubenwardy commented Aug 24, 2023

It makes the mouse_sensitivity setting visible again on ENABLE_TOUCH builds, as it also affects "finger sensitivity":

This will cause the Keyboard and Mouse page to reappear on Android, containing only the mouse sensitivity setting. Whilst eventually Android will have keyboard and mouse support, we do want this option appear on both pages so it's clear that it applies to touch pad as well. Unfortunately, setting name is a primary key in the new settings GUI which means that whilst a setting can appear multiple times, the definition must be the same.

So either we could make it so the settings GUI supports multiple setting definitions with the same name, or we should split this setting and add "touchscreen_sensitivity" as well.

If we keep with a single setting, a better name would be good

@grorp
Copy link
Member Author

grorp commented Aug 24, 2023

Adding a separate touchscreen_sensitivity setting sounds good.

@grorp
Copy link
Member Author

grorp commented Aug 24, 2023

Updated.

- Hide repeat_place_time on ENABLE_TOUCH builds as you cannot hold the dig button there

- Improve the description of safe_dig_and_place to cover ENABLE_TOUCH builds as well
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfan5 sfan5 merged commit 7b56daa into minetest:master Aug 27, 2023
13 checks passed
@grorp grorp deleted the small-setting-fixes branch December 18, 2023 16:38
kawogi pushed a commit to kawogi/minetest that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants