Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate download timeout to allow download of bigger files or on lo... #1379

Merged
merged 1 commit into from Jun 26, 2014
Merged

Add separate download timeout to allow download of bigger files or on lo... #1379

merged 1 commit into from Jun 26, 2014

Conversation

sapier
Copy link
Contributor

@sapier sapier commented Jun 15, 2014

...w bandwidth lines

@ShadowNinja
Copy link
Member

  1. Actual download time should be unlimited, but cancelable.
  2. This shouldn't be hardcoded.
  3. If it's a default it should be set in HTTPFetchRequest's constructor.

@sapier
Copy link
Contributor Author

sapier commented Jun 17, 2014

  1. I agree, but without a major change in the script API there's no way to cancel a synchronous operation.
  2. O.K. I'll add another setting.
  3. it's not a HTTP operation default, but only for file downloading. There's a big difference.

@sapier sapier added this to the 0.4.10 milestone Jun 20, 2014
@sapier sapier merged commit 13517fb into minetest:master Jun 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@ Script API
Projects
None yet
Milestone
0.4.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sapier @ShadowNinja @sfan5