Settings GUI: Noise parameter setting fixes #13797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't really make sense of the comment in the removed line. This *should* not break anything, not even in `generate_from_settingtypes.lua`. (That file uses `setting.default`, but only for settings which aren't noise parameter settings.)
sfan5
reviewed
Sep 12, 2023
Co-authored-by: rubenwardy <rw@rubenwardy.com>
|
You can consider the concerns I expressed in the commit message of 3b9759e as resolved, I tested this PR against the |
kawogi
pushed a commit
to kawogi/minetest
that referenced
this pull request
Dec 19, 2023
cosin15
pushed a commit
to cosin15/minetest
that referenced
this pull request
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two small fixes regarding noise parameter settings to the settings GUI:
[Manual Squash] Redesign/unify mainmenu settings interface #12480 accidentally didn't copy over these lines from the deleted
dlg_settings_advanced.luato the newly addeddlg_change_mapgen_flags.lua:minetest/builtin/mainmenu/dlg_settings_advanced.lua
Lines 963 to 967 in 1b95998
This means that if you change noise parameter flags using the checkboxes at the bottom of the noise parameter dialog, your changes won't be saved. This PR fixes that.
Also, noise parameter settings now show a reset button if they have been changed.
Of course, the noise parameter dialog could be improved a lot more, see #13476.
To do
This PR is a Ready for Review.
How to test
Verify that the noise parameter dialog saves your changes to the flags (aka the checkboxes).
Verify that a reset button is shown for changed noise parameter settings.