Extract updatePauseState from Game::run #13893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seeks to improve the readability of Game::run by extracting some of the behavior into a function. The inspiration for the refactor came from the beautiful chart in minetest#13879 showing the high-level overview of the logic flow in Game::run.
Zughy
added
Maintenance
sfan5
reviewed
Oct 16, 2023
Co-authored-by: sfan5 <sfan5@live.de>
sfan5
approved these changes
Oct 16, 2023
rubenwardy
approved these changes
Oct 16, 2023
Desour
requested changes
Oct 17, 2023
|
Thanks for catching the inconsistency before it was merged, @Desour! |
Desour
reviewed
Oct 18, 2023
Desour
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seeks to improve the readability of Game::run by extracting some of the behavior into a function. The inspiration for the refactor came from the beautiful chart in #13879 showing the high-level overview of the logic flow in Game::run.
To do
Ready for Review.
How to test
Confirm that in multiplayer the game keeps running in the background when the main menu is open, and that in singleplayer the game stops running in the background when the main menu is open. "stops running" should mean the animation stops, and the sound stops.