Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSM: Fix duplicate player names #13910

Merged
merged 2 commits into from
Oct 22, 2023
Merged

CSM: Fix duplicate player names #13910

merged 2 commits into from
Oct 22, 2023

Conversation

SmallJoker
Copy link
Member

Fixes #13898

To do

This PR is Ready for Review.

How to test

  1. Have a CSM mod enabled
  2. This:
minetest.register_chatcommand("p", {
    params = "command",
    func = function(param)
		local players = minetest.get_player_names()
		for i, v in pairs(players) do
			print(i, v)
		end
		return true, "---- END"
	end
})
  1. Only unique names must appear.

sfan5
sfan5 approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SmallJoker SmallJoker merged commit 2fbf5f4 into minetest:master Oct 22, 2023
13 checks passed
kawogi pushed a commit to kawogi/minetest that referenced this pull request Dec 19, 2023
@SmallJoker @kawogi
CSM: Fix duplicate player names (minetest#13910)
046bd9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug @ Client Script API One approval ✅ ◻️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minetest.get_player_names in CSM API duplicates current player
3 participants
@SmallJoker @sfan5 @Zughy