Fix bad translation function names in builtin #13977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenwardy
approved these changes
Nov 9, 2023
rubenwardy
added
@ Mainmenu
Trivial
grorp
approved these changes
Nov 9, 2023
|
I approve |
srifqi
approved these changes
Nov 10, 2023
cx384
pushed a commit
to cx384/minetest
that referenced
this pull request
Dec 9, 2023
kawogi
pushed a commit
to kawogi/minetest
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builtin had a few strings translated with the wrong function.
fgettext_newas aliased withgettextin a file but this is not correct becauseupdatepo.shdoes not recognize this name. Thus, a few strings were "overlooked" byupdatepo.sh.The fix is to remove this alias and call
fgettext_nedirectly at the offending places.Please add this to the 5.8.0 Milestone!
Please refresh translations with
updatepo.shafter merging this (and please Weblate as well) because it will reveal a few new strings it has previously overlooked.