Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sound volume when unfocused setting #14083

Merged
merged 10 commits into from
Dec 10, 2023
Merged

Add sound volume when unfocused setting #14083

merged 10 commits into from
Dec 10, 2023

Commits on Dec 7, 2023

  1. Add sound volume when unfocused setting

    @srifqi
    srifqi committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    1650915 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Make sound_volume_unfocused setting a multiplier

    @srifqi
    srifqi committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    6a4bf03 View commit details
    Browse the repository at this point in the history

  2. Add sound_volume_unfocused setting into set_default_settings()

    @srifqi
    srifqi committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    fd6f02a View commit details
    Browse the repository at this point in the history

  3. Use isWindowActive() to check window activity

    @srifqi
    srifqi committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    50a5b87 View commit details
    Browse the repository at this point in the history

  4. Make GUIEngine respects sound settings

    @srifqi
    srifqi committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    9ebac40 View commit details
    Browse the repository at this point in the history

  5. Create a helper function sound_control_by_window() 

    This function controls sound volume based on window state.
    @srifqi
    srifqi committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    415507d View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Move sound_control_by_window() definition to src/client/sound.cpp 

    The function is not static.
The settings parameter is removed. Global g_settings is used instead.
    @srifqi
    srifqi committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    8831dd0 View commit details
    Browse the repository at this point in the history

  2. Move includes

    @srifqi
    srifqi committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    d44912f View commit details
    Browse the repository at this point in the history

  3. Make the helper function just receive the needed value

    @srifqi
    srifqi committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    6512da5 View commit details
    Browse the repository at this point in the history

  4. Just a little change

    @srifqi
    srifqi committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    29918f3 View commit details
    Browse the repository at this point in the history