New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify bug report form #14154
Closed
Closed
Simplify bug report form #14154
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the instructions to get "Active renderer" and "Irrlicht device" fields from credits tab.
This is important now that we're switching to SDL, and might also switch to opengl 3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then let's add a short blurb about how to find that information.
I recently opened an issue and I personally found it daunting and I work on MT. :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one of the things I really wanted to remove as it's fairly meaningless to users and not relevant to all issues. The current form doesn't even say what an Irrlicht device is or how to find it out.
This is included as part of the version information if you do --version. We need #13605
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It says:
This used to be above active renderer and irrlicht device. It was incorrectly moved to active renderer only on the change to non-text-only issue form.
That's because you can usually conclude it from the OS and minetest version. We can maybe write that the information needs only to be supplied if non-default build options were used.
(Non-trivial to add in
--version
, because as of now it doesn't create an irrlicht device.)You also need to consider that issues may be opened from the current stable version, i.e. 5.8.0, where there's no export button or similar for this.