ContentCAO: Fix threshold of alpha channel textures #14213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With disabled shaders, the material EMT_TRANSPARENT_ALPHA_CHANNEL uses the parameter as an alpha threshold to decide whether to draw the texture. Thus lowering this limit fixes the issue of vanishing textures below alpha 128.
Fixes #14204
To do
This PR is Ready for Review.
How to test
1.- Set enable_shaders = false in MT
2. Install the Citadel game (ContentDB)
3. Teleport/travel to (5, 2, 12)
4. Look south and upwards, and see (or don't) the ghost
5. edit
games/citadel/mods/citadel_core/ghost.lua
. Modify the opacity in the lineself.object:set_texture_mod
to 10, 127, 128 and make sure the texture is still rendered.