New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glTF model support #14234
Draft
appgurueu
wants to merge
6
commits into
minetest:master
Choose a base branch
from
appgurueu:feat/gltf-loader
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
glTF model support #14234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
added
WIP
The PR is still being worked on by its author and not ready yet.
Roadmap
The change matches an item on the current roadmap.
labels
Jan 12, 2024
sfan5
added
the
Waiting (on dependency)
Waiting on another PR or external circumstances (not for rebases/changes requested)
label
Jan 17, 2024
7 tasks
sfan5
added
Rebase needed
The PR needs to be rebased by its author.
and removed
Waiting (on dependency)
Waiting on another PR or external circumstances (not for rebases/changes requested)
labels
Apr 13, 2024
Rebase needed after IrrlichtMt merge. |
Too WIP, removed from 5.9 milestone. Please work on this as gltf is a very desired feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@ Client rendering
Feature ✨
PRs that add or enhance a feature
Rebase needed
The PR needs to be rebased by its author.
Roadmap
The change matches an item on the current roadmap.
WIP
The PR is still being worked on by its author and not ready yet.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
(WIP, PRs 2 and 3 are pending review by Josiah.)
To do
either by bundling the jsoncpp amalgamation like Minetest or getting sfan to add Jsoncpp to the available system packagesfixed by forking jsoncpp and fetching it viaFetchContent
).How to test
ctest --output-on-failure
(inside theirrlicht
dir).Screencast.from.09-01-24.00.47.45.webm
Trivia
The work to make this possible was done by what I would call Minetest's "inofficial gltf working group" - Josiah, Jordan, and me. The spider model used for testing was made by archfan.