Add flag to control mgv6 temple generation #14293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zughy
added
Concept approved
SmallJoker
reviewed
Jan 28, 2024
There was a problem hiding this comment.
Found temples by using an all-desert biome + c_lava_source wall material for highlight
Map seed: 0
Position: -20,-230,380
☑️ Temples are on by default
☑️ Turning them off in map_meta.txt works. Compared the dummy backend world before/after.
The temple in question:
SmallJoker
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13413
To do
This PR is Ready for Review.
How to test
templesafter you join itnotemples. Locate a desert and find a dungeon. Ensure it looks like a normal one (made of cobble, small rooms).Hint: MTG dungeon_loot can print the positions it has found. If you edit
MapgenV6::getBiomeyou can turn everything into desert.