Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support absent scene node names #14330

Merged
merged 2 commits into from Feb 18, 2024

Conversation

appgurueu
Copy link
Contributor

Trivial corresponding Minetest changes for minetest/irrlicht#284

@appgurueu appgurueu added the Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines label Jan 30, 2024
@appgurueu appgurueu added the Waiting (on dependency) Waiting on another PR or external circumstances (not for rebases/changes requested) label Feb 6, 2024
appgurueu referenced this pull request in minetest/irrlicht Feb 14, 2024
@sfan5
Copy link
Member

sfan5 commented Feb 17, 2024

For testing reasons it would be useful if you made this work with an #if depending on the revision.

@sfan5 sfan5 removed the Waiting (on dependency) Waiting on another PR or external circumstances (not for rebases/changes requested) label Feb 17, 2024
@appgurueu appgurueu merged commit 4acbd59 into minetest:master Feb 18, 2024
13 checks passed
appgurueu added a commit to y5nw/minetest that referenced this pull request Mar 4, 2024
Contains a hack to support IrrlichtMT revision 14 for now (until we release revision 15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants