Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined behaviors #14365

Merged
merged 3 commits into from Feb 15, 2024
Merged

Fix undefined behaviors #14365

merged 3 commits into from Feb 15, 2024

Conversation

fuzun
Copy link
Contributor

@fuzun fuzun commented Feb 11, 2024

These were spotted using undefined behavior sanitizer.

appgurueu
appgurueu reviewed Feb 11, 2024
View reviewed changes
src/tool.cpp Outdated Show resolved Hide resolved
appgurueu
appgurueu reviewed Feb 11, 2024
View reviewed changes
src/mapgen/mg_biome.cpp Outdated Show resolved Hide resolved
sfan5
sfan5 reviewed Feb 11, 2024
View reviewed changes
src/nodedef.cpp Outdated Show resolved Hide resolved
@Zughy Zughy added Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Code quality labels Feb 11, 2024
appgurueu
appgurueu approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@appgurueu appgurueu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke-tested mapgen consistency a bit (there should be no issues, though - the assembly that's executed for values within s64 bounds, which we should be staying in with a lot of margin, should be the same), seems to work fine. Thanks.

@sfan5 sfan5 merged commit 6cbb919 into minetest:master Feb 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 left review comments

@appgurueu appgurueu appgurueu approved these changes

Assignees
No one assigned
Labels
Code quality Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fuzun @sfan5 @appgurueu @Zughy