Do not link /latomic on MSVC #14564
Merged
Do not link /latomic on MSVC #14564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC does not recognize /latomic.
|
We had this before and it didn't work, see #14160 |
|
Perhaps we should check whether some code compiles without the |
|
Note that this is not equivalent to what was there before. This change is safe because it still does the compile check. |
|
If you want to avoid a warning on MSVC I'd rather skip this part on MSVC, instead of a whitelist approach. |
sfan5
added
the
@ Build
JosiahWI
changed the title
sfan5
added
the
Trivial
sfan5
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC does not recognize /latomic.
To do
Ready for Review.
How to test
Compile on MSVC and observe that there is no longer any warning about an unrecognized
/latomicoption.