Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable fog toggle unless server restricts fog distance #14634

Merged
merged 1 commit into from
May 14, 2024

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented May 9, 2024

IMO disabling fog is still stupid even visually, compare these two:

grafik grafik
fog_start=0.99 fog disabled

To do

This PR is Ready for Review.

How to test

should be obvious

@Montandalar
Copy link
Contributor

Thank you sfan5 for compromising on this.

Tested, works. Can enable fog in vanilla MTG; can't disable it in Shadow Forest.

doc/lua_api.md Outdated Show resolved Hide resolved
@Sokomine
Copy link
Contributor

Thank you for implementing this!

I commented on the screenshots in the main discussion so that it stays more together.

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with worldedit_commands :

//lua minetest.get_connected_players()[1]:set_sky({ fog = { fog_distance = 10 }})
//lua minetest.get_connected_players()[1]:set_sky({ fog = { fog_distance = -1 }})

Works on my machine.

doc/lua_api.md Outdated Show resolved Hide resolved
src/client/game.cpp Outdated Show resolved Hide resolved
@sfan5
Copy link
Member Author

sfan5 commented May 12, 2024

Tested with worldedit_commands :

pro tip: you can now use //lua player:whatever_method()

@lhofhansl
Copy link
Contributor

Makes sense, and looks good. +1

@Sokomine
Copy link
Contributor

Hope it gets merged soon?

@sfan5 sfan5 merged commit c38e0d0 into minetest:master May 14, 2024
13 checks passed
@sfan5 sfan5 deleted the fog2 branch May 14, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants