-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable fog toggle unless server restricts fog distance #14634
Conversation
Thank you sfan5 for compromising on this. Tested, works. Can enable fog in vanilla MTG; can't disable it in Shadow Forest. |
Thank you for implementing this! I commented on the screenshots in the main discussion so that it stays more together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with worldedit_commands
:
//lua minetest.get_connected_players()[1]:set_sky({ fog = { fog_distance = 10 }})
//lua minetest.get_connected_players()[1]:set_sky({ fog = { fog_distance = -1 }})
Works on my machine.
pro tip: you can now use |
Makes sense, and looks good. +1 |
Hope it gets merged soon? |
IMO disabling fog is still stupid even visually, compare these two:
To do
This PR is Ready for Review.
How to test
should be obvious