Add animated glTF support #14685
Draft
Add animated glTF support #14685
+3,464
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
added
@ Script API
Roadmap
appgurueu
force-pushed
the
feat/gltf-loader++
branch
2 times, most recently
from
ac7bb44
to
0526309
Compare
Co-authored-by: sfan5 <sfan5@live.de>
This also corrects the function name to be snake_case because it is not a method.
appgurueu
force-pushed
the
feat/gltf-loader++
branch
2 times, most recently
from
6b576c0
to
3ebf27c
Compare
appgurueu
force-pushed
the
feat/gltf-loader++
branch
from
3ebf27c
to
7dd13bc
Compare
|
Rebased. The static PR is ready. This is ready too. The diff after the static PR is merged amounts to about 400 loc, as can be seen here: JosiahWI/minetest@feat/gltf-loader...appgurueu:minetest:feat/gltf-loader++. |
appgurueu
force-pushed
the
feat/gltf-loader++
branch
from
84c5373
to
d9a37a2
Compare
|
To clarify the state of this PR: This PR is ready for review, as is the static PR. It depends on the static PR however, hence the "waiting on dependency" tag. It is probably a good idea to review the static PR first, until it is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the follow-up to #14557.
How to test
Test entities and unit tests are included.