Add --terminal-silent flag to minetest #14734
Conversation
jordan4ibanez
force-pushed
the
terminal-silent
branch
2 times, most recently
from
d369461
to
46dc675
Compare
rubenwardy
added
@ Startup / Config / Util
Feature ✨
any examples of what to type? |
|
|
In case there's any other confusion as to what I mean by, you can directly type into the terminal (stdin), here is an image. |
Do a minor module update Document this I gave it sleeping medicine slow it down, use portable, be sassy Add terminal-silent ability to minetest Start the guttening make it clean wot I can't believe this actually works Time for more fun checkpoint Almost there Getting better horrors beyond human comprehension WE HAVE LIFTOFF BOIS WOOOOO I have absolutely no idea what I'm doing gut it top tier debug info Found my typo there ur hell literally duct tape this on fix tabs Now check for silent Now only silent import Silent Silent thing Integrate terminal-silent I worded this badly Remove this comment
jordan4ibanez
force-pushed
the
terminal-silent
branch
from
b147896
to
3c3ce4e
Compare
|
Here is a video of a use case for it: https://youtu.be/X2O0gKai1CI Here is the repo for the gui used in the video: https://github.com/jordan4ibanez/minetest_gui |
| @@ -374,6 +375,8 @@ static void set_allowed_options(OptionList *allowed_options) | |||
| _("Migrate from current mod storage backend to another (Only works when using minetestserver or with --server)")))); | |||
| allowed_options->insert(std::make_pair("terminal", ValueSpec(VALUETYPE_FLAG, | |||
| _("Feature an interactive terminal (Only works when using minetestserver or with --server)")))); | |||
| allowed_options->insert(std::make_pair("terminal-silent", ValueSpec(VALUETYPE_FLAG, | |||
There was a problem hiding this comment.
maybe something like stdin-control would be a better name
| @@ -1089,7 +1092,7 @@ static bool run_dedicated_server(const GameParams &game_params, const Settings & | |||
| return false; | |||
| } | |||
|
|
|||
| if (cmd_args.exists("terminal")) { | |||
| if (cmd_args.exists("terminal") || cmd_args.exists("terminal-silent")) { | |||
| #if USE_CURSES | |||
There was a problem hiding this comment.
there's no reason for the silent option to depend on curses.
would be counterproductive because you want to use it especially when you don't have curses
| g_term_console_silent.stopAndWaitforThread(); | ||
| } else { | ||
| g_term_console.stopAndWaitforThread(); | ||
| } |
There was a problem hiding this comment.
this if-else dance could be avoided by defining an interface these two classes inherit
| } | ||
|
|
||
| MutexedQueue<std::pair<LogLevel, std::string> > queue; | ||
| }; |
There was a problem hiding this comment.
doesn't minetest log to stdout anyway? or is that inhibited with curses enabled?
I don't see the point of this.
| // If you are running 100 commands per second, you might want to | ||
| // redesign the program interfacing with the server. | ||
| // This keeps the thread from maxing out the cpu core. | ||
| std::this_thread::sleep_for(std::chrono::milliseconds(10)); |
There was a problem hiding this comment.
no need for nonblock (which afaik could also cause problems with logging) and the sleeping.
you can simply poll with a timeout of e.g. 1s (so it still exits correctly)
|
|
||
| // Print if its a command (gets eaten by server otherwise) | ||
| if (msg[0] == L'/') { | ||
| m_chat_backend.addMessage(L"", (std::wstring)L"Issued command: " + msg); |
There was a problem hiding this comment.
m_chat_backend is totally unused except for this
sfan5
added
Supported by core dev
Add compact, short information about your PR for easier understanding:
It allows you to hook in GUIs and also as a side effect you can type straight into the regular terminal.
Some way to directly talk to minetest through the command line.
It uses cin nonblocking with std::thread::sleep_for() (thanks Lars && ExeVirus) on another thread via the ILogOutput and Thread parent classes to get this pipe dream functioning.
I have no idea.
Still no idea.
Because you should be able to talk to your local server through the terminal when it's being handled by other apps.
To do
This PR is a Ready for Review.
How to test
First, make sure your minetest.conf has
Next, build with this pr, launch
minetestserverorminetest --serverwith the flag--terminal-silentand then type straight into the terminal.